Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve omni.isaac.lab_tasks loading time #1353

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Conversation

Toni-SM
Copy link
Contributor

@Toni-SM Toni-SM commented Oct 31, 2024

Description

Improve omni.isaac.lab_tasks loading time

(13th Gen Intel® Core™ i9-13950HX × 32)

  • Before: 3.66 seconds
  • After: 84 milliseconds

Screenshots

Original (no changes)
Screenshot from 2024-10-27 09-32-44

Define task entry points as string when registering
Screenshot from 2024-10-27 18-12-20

Define task entry points as string when registering + Ignore mdp directories during import.
Screenshot from 2024-10-28 10-20-00

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 merged commit 6bf87f3 into main Nov 4, 2024
5 checks passed
@kellyguo11 kellyguo11 deleted the toni/perf/lab_tasks_import branch November 4, 2024 17:59
kemjensak added a commit to IROL-SSU/IsaacLab that referenced this pull request Nov 5, 2024
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
# Description

Improve omni.isaac.lab_tasks loading time

(13th Gen Intel® Core™ i9-13950HX × 32)
* Before: 3.66 seconds
* After: 84 milliseconds

## Screenshots

Original (no changes)
![Screenshot from 2024-10-27
09-32-44](https://github.com/user-attachments/assets/2245d1c3-b0c8-47fc-8bc3-dd09c5e5303d)

Define task entry points as string when registering
![Screenshot from 2024-10-27
18-12-20](https://github.com/user-attachments/assets/574fbddd-cd77-4b78-83ea-99c21dbcb214)

Define task entry points as string when registering + Ignore `mdp`
directories during import.
![Screenshot from 2024-10-28
10-20-00](https://github.com/user-attachments/assets/6fe6744c-ad2c-42fc-b6fa-ae1966281cbb)


## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Co-authored-by: Mayank Mittal <mittalma@leggedrobotics.com>
Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants