Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve omni.isaac.lab_tasks loading time #1353

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improve omni.isaac.lab_tasks loading time #1353

wants to merge 8 commits into from
+192 −140

Conversation

Toni-SM
Copy link
Contributor

@Toni-SM Toni-SM commented Oct 31, 2024

Description

Improve omni.isaac.lab_tasks loading time

(13th Gen Intel® Core™ i9-13950HX × 32)

  • Before: 3.66 seconds
  • After: 84 milliseconds

Screenshots

Original (no changes)
Screenshot from 2024-10-27 09-32-44

Define task entry points as string when registering
Screenshot from 2024-10-27 18-12-20

Define task entry points as string when registering + Ignore mdp directories during import.
Screenshot from 2024-10-28 10-20-00

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhoeller19 Dhoeller19 Awaiting requested review from Dhoeller19 Dhoeller19 is a code owner

@Mayankm96 Mayankm96 Awaiting requested review from Mayankm96 Mayankm96 is a code owner

@jsmith-bdai jsmith-bdai Awaiting requested review from jsmith-bdai jsmith-bdai is a code owner

@jtigue-bdai jtigue-bdai Awaiting requested review from jtigue-bdai jtigue-bdai is a code owner

@kellyguo11 kellyguo11 Awaiting requested review from kellyguo11 kellyguo11 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Toni-SM @Mayankm96