-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds distributed multi-GPU learning support for skrl #574
Merged
Dhoeller19
merged 8 commits into
isaac-sim:main
from
Toni-SM:toni/update_skrl_integration
Jun 27, 2024
Merged
Adds distributed multi-GPU learning support for skrl #574
Dhoeller19
merged 8 commits into
isaac-sim:main
from
Toni-SM:toni/update_skrl_integration
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acLab into toni/update_skrl_integration
Mayankm96
changed the title
Update skrl integration and add distributed multi-GPU learning support
Adds distributed multi-GPU learning support for skrl
Jun 26, 2024
Mayankm96
reviewed
Jun 26, 2024
Mayankm96
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for sending the MR. Looking forward to trying out multi-GPU training :)
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Beautiful! |
Dhoeller19
approved these changes
Jun 27, 2024
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
This PR updates `skrl` to version `>=1.2.0` and include the support for distributed multi-gpu learning in Isaac Lab docs, See [skrl-v1.2.0](https://github.com/Toni-SM/skrl/releases/tag/1.2.0) for more details ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
This PR updates `skrl` to version `>=1.2.0` and include the support for distributed multi-gpu learning in Isaac Lab docs, See [skrl-v1.2.0](https://github.com/Toni-SM/skrl/releases/tag/1.2.0) for more details ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
skrl
to version>=1.2.0
and include the support for distributed multi-gpu learning in Isaac Lab docs,See skrl-v1.2.0 for more details
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
./isaaclab.sh --test
and they passconfig/extension.toml
fileCONTRIBUTORS.md
or my name already exists there