Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds distributed multi-GPU learning support for skrl #574

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

Toni-SM
Copy link
Contributor

@Toni-SM Toni-SM commented Jun 26, 2024

Description

This PR updates skrl to version >=1.2.0 and include the support for distributed multi-gpu learning in Isaac Lab docs,
See skrl-v1.2.0 for more details

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the tests with ./isaaclab.sh --test and they pass
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Mayankm96 Mayankm96 changed the title Update skrl integration and add distributed multi-GPU learning support Adds distributed multi-GPU learning support for skrl Jun 26, 2024
Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for sending the MR. Looking forward to trying out multi-GPU training :)

@Mayankm96 Mayankm96 self-assigned this Jun 26, 2024
@Mayankm96 Mayankm96 added the enhancement New feature or request label Jun 26, 2024
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
@Dhoeller19
Copy link
Collaborator

Beautiful!

@Dhoeller19 Dhoeller19 merged commit 35345c6 into isaac-sim:main Jun 27, 2024
2 checks passed
@Toni-SM Toni-SM deleted the toni/update_skrl_integration branch June 27, 2024 14:00
fatimaanes pushed a commit to fatimaanes/omniperf that referenced this pull request Aug 8, 2024
This PR updates `skrl` to version `>=1.2.0` and include the support for
distributed multi-gpu learning in Isaac Lab docs,
See [skrl-v1.2.0](https://github.com/Toni-SM/skrl/releases/tag/1.2.0)
for more details

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
This PR updates `skrl` to version `>=1.2.0` and include the support for
distributed multi-gpu learning in Isaac Lab docs,
See [skrl-v1.2.0](https://github.com/Toni-SM/skrl/releases/tag/1.2.0)
for more details

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./isaaclab.sh --test` and they pass
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants