Reads gravity direction from simulation inside RigidObjectData
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
RigidObjectDataRigidObjectData
Dhoeller19
approved these changes
Jun 27, 2024
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
…ac-sim#582) # Description Previously, the gravity direction inside the `RigidObjectData` class was hard-coded as (0, 0, -1). However, this quantity may have a different direction in some simulation situations. This MR removes this hard coding and directly reads the value from the simulation view. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…ac-sim#582) # Description Previously, the gravity direction inside the `RigidObjectData` class was hard-coded as (0, 0, -1). However, this quantity may have a different direction in some simulation situations. This MR removes this hard coding and directly reads the value from the simulation view. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the gravity direction inside the
RigidObjectDataclass was hard-coded as (0, 0, -1). However, this quantity may have a different direction in some simulation situations. This MR removes this hard coding and directly reads the value from the simulation view.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --format./isaaclab.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there