Fixes sphinx tabs to make them work in dark theme #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
added
bug
Mayankm96
changed the title
Dhoeller19
approved these changes
Jun 27, 2024
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
Earlier, we used the `sphinx-tabs` module, which didn't work well with the `sphinx-book-theme` of our documentation. This MR removes this dependency and uses `sphinx-design` instead for tabs. This natively supports the dark theme. ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Screenshots https://github.com/isaac-sim/IsaacLab/assets/12863862/a56e1fa4-9b3c-4161-83bd-95b0e3b10334 ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
Earlier, we used the `sphinx-tabs` module, which didn't work well with the `sphinx-book-theme` of our documentation. This MR removes this dependency and uses `sphinx-design` instead for tabs. This natively supports the dark theme. ## Type of change - Bug fix (non-breaking change which fixes an issue) - This change requires a documentation update ## Screenshots https://github.com/isaac-sim/IsaacLab/assets/12863862/a56e1fa4-9b3c-4161-83bd-95b0e3b10334 ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have run all the tests with `./isaaclab.sh --test` and they pass - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier, we used the
sphinx-tabsmodule, which didn't work well with thesphinx-book-themeof our documentation. This MR removes this dependency and usessphinx-designinstead for tabs. This natively supports the dark theme.Type of change
Screenshots
dark-theme.mp4
Checklist
pre-commitchecks with./isaaclab.sh --format./isaaclab.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there