Fixes the rendering logic regression in environments #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/test/envs/test_env_rendering_logic.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/test/envs/test_env_rendering_logic.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/direct_rl_env.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/test/envs/test_env_rendering_logic.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/test/envs/test_env_rendering_logic.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
changed the title
Mayankm96
force-pushed
the
fix/render_logic
branch
from
0f068c9
to
588b88d
Compare
Mayankm96
approved these changes
Jul 2, 2024
mohanksriram
pushed a commit
to mohanksriram/IsaacLab
that referenced
this pull request
Jul 12, 2024
# Description The previous rendering logic had a bug where a render call would also step physics `render_interval` number of times. This was a regression introduced in 59493b8 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description The previous rendering logic had a bug where a render call would also step physics `render_interval` number of times. This was a regression introduced in 5fa9887 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description The previous rendering logic had a bug where a render call would also step physics `render_interval` number of times. This was a regression introduced in 59493b8 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous rendering logic had a bug where a render call would also step physics
render_intervalnumber of times.This was a regression introduced in 59493b8
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there