Adds IMU sensor
#619
Merged
Adds IMU sensor
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Jul 2, 2024
Mayankm96
reviewed
Jul 2, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu_data.py
Outdated
Show resolved
Hide resolved
Signed-off-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com>
|
@Mayankm96, ok all changes were implemented. Looks like some CI isn't passing but I don't have access to diagnose. |
pascal-roth
commented
Oct 7, 2024
Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
|
Could you please review and merge this pull request at your earliest convenience? I need it for my project ASAP. |
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu_data.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu_data.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu_data.py
Outdated
Show resolved
Hide resolved
jtigue-bdai
reviewed
Oct 14, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/imu/imu_data.py
Outdated
Show resolved
Hide resolved
Co-authored-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
Signed-off-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
approved these changes
Oct 18, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description Add `IMU` sensor with cfg class `IMUCfg` and data class `IMUData`. Compared to the Isaac Sim implementation of the IMU Sensor, this sensor directly accesses the PhysX view buffers for speed acceleration. This PR also moves and renames a utility used for cameras to a general utility location. Fixes isaac-sim#440 ## Type of change - New feature (non-breaking change which adds functionality) - Breaking change ( ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
IMUsensor with cfg classIMUCfgand data classIMUData. Compared to the Isaac Sim implementation of the IMU Sensor, this sensor directly accesses the PhysX view buffers for speed acceleration.This PR also moves and renames a utility used for cameras to a general utility location.
Fixes #440
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there