Fixes `isaaclab` scripts to deal with Isaac Sim pip installation #631

Mayankm96 · 2024-07-03T18:31:40Z

Description

Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts isaaclab.sh and isaaclab.bat to now check for PIP package installation and get paths from there if they exist.

Fixes #516, #629

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

I have run the pre-commit checks with ./isaaclab.sh --format
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have updated the changelog and the corresponding version in the extension's config/extension.toml file
I have added my name to the CONTRIBUTORS.md or my name already exists there

isaaclab.bat

.vscode/tools/setup_vscode.py

isaaclab.bat

Mayankm96 · 2024-07-04T08:59:48Z

@kellyguo11 could you try again? Feel free to modify the branch/MR directly with the fixes needed for Windows

Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>

…nto fix/isaaclab-script

kellyguo11 · 2024-07-04T14:38:57Z

Pushed a few minor fixes, working for me on windows now

Mayankm96 · 2024-07-04T23:52:02Z

I had to remove the default vscode setting up from the install script as it calls import isaacsim now which at its very first call expects a user input for EULA. This doesn't work nicely when we want to call the install instructions inside a docker.

isaaclab.sh

# Description Realized that #631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there

…ac-sim#631) # Description Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts `isaaclab.sh` and `isaaclab.bat` to now check for PIP package installation and get paths from there if they exist. Fixes isaac-sim#516, isaac-sim#629 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>

) # Description Realized that isaac-sim#631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there

…ac-sim#631) # Description Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts `isaaclab.sh` and `isaaclab.bat` to now check for PIP package installation and get paths from there if they exist. Fixes isaac-sim#516, isaac-sim#629 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>

) # Description Realized that isaac-sim#631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there

…ac-sim#631) # Description Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts `isaaclab.sh` and `isaaclab.bat` to now check for PIP package installation and get paths from there if they exist. Fixes isaac-sim#516, isaac-sim#629 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>

) # Description Realized that isaac-sim#631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there

Mayankm96 added 6 commits July 3, 2024 18:17

adds initial fix

a63d97e

working setup without env file

c739249

works without any other code

d09fff0

runs formatter

9d92b49

runs formatter

f568db5

fix scripts to use isaacsim pip paths

0327c3a

Mayankm96 requested review from Dhoeller19 and kellyguo11 July 3, 2024 18:31

Mayankm96 added the bug Something isn't working label Jul 3, 2024

Mayankm96 added 6 commits July 3, 2024 23:02

gets path correclty

acbda9a

checks steps for bash

1234de4

adds dockerfile for pip installation

08a57cf

adds python in pip dockerfile

43682be

fixes docs

ce363cc

fixes vscode setup on launch

c51cce3

Mayankm96 changed the title ~~Fixes the isaac-lab scripts to corrcetly deal with pip package installation~~ Fixes isaaclab scripts to deal with Isaac Sim pip installation Jul 3, 2024

Mayankm96 self-assigned this Jul 3, 2024

runs formatter

c85f119

kellyguo11 reviewed Jul 4, 2024

View reviewed changes

isaaclab.bat Outdated Show resolved Hide resolved

.vscode/tools/setup_vscode.py Outdated Show resolved Hide resolved

.vscode/tools/setup_vscode.py Outdated Show resolved Hide resolved

isaaclab.bat Show resolved Hide resolved

isaaclab.bat Outdated Show resolved Hide resolved

Mayankm96 added 2 commits July 4, 2024 07:27

fixes based on kelly

682882b

adds throwing error for wrong python version

df24b93

Mayankm96 mentioned this pull request Jul 4, 2024

[Bug Report] Failed to install isaaclab via pip #480

Closed

4 tasks

Base automatically changed from fix/vs-code-settings to main July 4, 2024 11:12

Merge branch 'main' into fix/isaaclab-script

ea93778

Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>

This was referenced Jul 4, 2024

Fixes VSCode settings to work with pip installation of Isaac Sim #628

Merged

[Bug Report] Isaac Lab PIP Installation and Vscode Setup #629

Closed

Mayankm96 and others added 3 commits July 4, 2024 16:24

Merge branch 'main' into fix/isaaclab-script

2cc68fe

fix backslash in paths

cc26f0a

Merge branch 'fix/isaaclab-script' of github.com:isaac-sim/IsaacLab i…

d7881ce

…nto fix/isaaclab-script

Mayankm96 added 3 commits July 5, 2024 01:36

makes yq installation not mandatory

bdd772e

simplify logic in windows

1cc8e21

deals with docker container cases

64d928b

Mayankm96 requested a review from kellyguo11 July 4, 2024 23:50

fixes for windows script

0be5e7e

kellyguo11 reviewed Jul 5, 2024

View reviewed changes

isaaclab.sh Outdated Show resolved Hide resolved

Mayankm96 added 2 commits July 5, 2024 10:09

deals with corner cases

5d050c6

runs formatter

467c272

Mayankm96 requested a review from kellyguo11 July 5, 2024 08:09

Mayankm96 added 3 commits July 5, 2024 10:16

adds back vscode setting

bff56ae

runs formatter

07a6ea4

better warning

a496c29

kellyguo11 approved these changes Jul 5, 2024

View reviewed changes

Mayankm96 merged commit 07f082f into main Jul 5, 2024
3 checks passed

Mayankm96 deleted the fix/isaaclab-script branch July 5, 2024 16:06

Mayankm96 mentioned this pull request Jul 5, 2024

Fixes isaaclab.sh script to deal with local system python #649

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes `isaaclab` scripts to deal with Isaac Sim pip installation #631

Fixes `isaaclab` scripts to deal with Isaac Sim pip installation #631

Mayankm96 commented Jul 3, 2024 •

edited

Loading

Mayankm96 commented Jul 4, 2024

kellyguo11 commented Jul 4, 2024

Mayankm96 commented Jul 4, 2024

Fixes isaaclab scripts to deal with Isaac Sim pip installation #631

Fixes isaaclab scripts to deal with Isaac Sim pip installation #631

Conversation

Mayankm96 commented Jul 3, 2024 • edited Loading

Description

Type of change

Checklist

Mayankm96 commented Jul 4, 2024

kellyguo11 commented Jul 4, 2024

Mayankm96 commented Jul 4, 2024

Fixes `isaaclab` scripts to deal with Isaac Sim pip installation #631

Fixes `isaaclab` scripts to deal with Isaac Sim pip installation #631

Mayankm96 commented Jul 3, 2024 •

edited

Loading