-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizes interactive scene for homogeneous cloning #636
Conversation
…cs replication cfg
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
Addressed the comments. For the list argument in |
I don't think that is a breaking API change since it was a default argument. I don't think anyone was calling filter_collisions multiple times so far so we should be able to do this change without any breaking of the API itself. Though if you think it is better, we can make a separate MR for it. We should fix it though :) |
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/scene/interactive_scene.py
Show resolved
Hide resolved
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
# Description Previously, we always assumed heterogeneous environment setup, which performed cloning on a per-actor basis during spawning of actors. In some direct workflow environments, a redundant cloning call was made at the end of environment setup to perform cloning on a global scope. With this change, we determine whether to perform cloning on a per-actor or global scope based on the `replicate_physics` parameter in `InteractiveSceneCfg`. When `replicate_physics=True`, homogeneous environment is assumed and cloning will only happen on a global scope. This reduces the time required for cloning for homogeneous setups. For heterogeneous environments, set `replicate_physics=False` and cloning will happen per-actor. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
# Description Previously, we always assumed heterogeneous environment setup, which performed cloning on a per-actor basis during spawning of actors. In some direct workflow environments, a redundant cloning call was made at the end of environment setup to perform cloning on a global scope. With this change, we determine whether to perform cloning on a per-actor or global scope based on the `replicate_physics` parameter in `InteractiveSceneCfg`. When `replicate_physics=True`, homogeneous environment is assumed and cloning will only happen on a global scope. This reduces the time required for cloning for homogeneous setups. For heterogeneous environments, set `replicate_physics=False` and cloning will happen per-actor. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
# Description Previously, we always assumed heterogeneous environment setup, which performed cloning on a per-actor basis during spawning of actors. In some direct workflow environments, a redundant cloning call was made at the end of environment setup to perform cloning on a global scope. With this change, we determine whether to perform cloning on a per-actor or global scope based on the `replicate_physics` parameter in `InteractiveSceneCfg`. When `replicate_physics=True`, homogeneous environment is assumed and cloning will only happen on a global scope. This reduces the time required for cloning for homogeneous setups. For heterogeneous environments, set `replicate_physics=False` and cloning will happen per-actor. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Description
Previously, we always assumed heterogeneous environment setup, which performed cloning on a per-actor basis during spawning of actors. In some direct workflow environments, a redundant cloning call was made at the end of environment setup to perform cloning on a global scope.
With this change, we determine whether to perform cloning on a per-actor or global scope based on the
replicate_physics
parameter inInteractiveSceneCfg
. Whenreplicate_physics=True
, homogeneous environment is assumed and cloning will only happen on a global scope. This reduces the time required for cloning for homogeneous setups. For heterogeneous environments, setreplicate_physics=False
and cloning will happen per-actor.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there