Fixes training UR10 reach with RL_GAMES and SKRL #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…py file in ur10.agents folder
Dhoeller19
changed the title
Dhoeller19
changed the title
Dhoeller19
approved these changes
Jul 17, 2024
|
Thanks a lot @sudhirpratapyadav! |
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description - Fixes isaac-sim#541 - **Bug description:** UR10 reach can be trained with RSL_RL but not with RL_GAMES and SKRL. - **Why this problem occurs:** The actual problem is there is no `__init__.py` file in the `agents` folder inside ur_10. Therefore when `mod_path = os.path.dirname(importlib.import_module(mod_name).__file__)` line is executed it gives error as `importlib.import_module(mod_name).__file__` is not able to find the module `omni.isaac.lab_tasks.manager_based.manipulation.reach.config.ur_10.agents`. ## Fixes - `__init__.py` file is added inside the ur_10.agents folder. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description - Fixes isaac-sim#541 - **Bug description:** UR10 reach can be trained with RSL_RL but not with RL_GAMES and SKRL. - **Why this problem occurs:** The actual problem is there is no `__init__.py` file in the `agents` folder inside ur_10. Therefore when `mod_path = os.path.dirname(importlib.import_module(mod_name).__file__)` line is executed it gives error as `importlib.import_module(mod_name).__file__` is not able to find the module `omni.isaac.lab_tasks.manager_based.manipulation.reach.config.ur_10.agents`. ## Fixes - `__init__.py` file is added inside the ur_10.agents folder. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
__init__.pyfile in theagentsfolder inside ur_10. Therefore whenmod_path = os.path.dirname(importlib.import_module(mod_name).__file__)line is executed it gives error asimportlib.import_module(mod_name).__file__is not able to find the moduleomni.isaac.lab_tasks.manager_based.manipulation.reach.config.ur_10.agents.Fixes
__init__.pyfile is added inside the ur_10.agents folder.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there