Fixes warning message in Articulation config processing #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luis Carranza <luis.carranza@estudiantat.upc.edu>
Dhoeller19
changed the title
Dhoeller19
approved these changes
Jul 23, 2024
|
Thanks @locoxsoco! |
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
# Description Fixes isaac-sim#698 The sanity check compares the total actuator joints (total_act_joints) with the difference between the number of joints minus the number of fixed tendons (self.num_joints - self.num_fixed_tendons), but the warning message displays a comparison between total_act_joints and self.num_joints. This is misleading on complex robots that includes fixed tendons such as Franka hand. ## Type of change - Bug fix (non-breaking change which fixes an issue)
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description Fixes isaac-sim#698 The sanity check compares the total actuator joints (total_act_joints) with the difference between the number of joints minus the number of fixed tendons (self.num_joints - self.num_fixed_tendons), but the warning message displays a comparison between total_act_joints and self.num_joints. This is misleading on complex robots that includes fixed tendons such as Franka hand. ## Type of change - Bug fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #698
The sanity check compares the total actuator joints (total_act_joints) with the difference between the number of joints minus the number of fixed tendons (self.num_joints - self.num_fixed_tendons), but the warning message displays a comparison between total_act_joints and self.num_joints. This is misleading on complex robots that includes fixed tendons such as Franka hand.
Type of change