Adds throughput benchmarking scripts for different learning workflows #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description - Adds a new script to run benchmark without RL in the loop - Adds a new script to run benchmark with RL Games - Adds a new script to run benchmark with RSL RL ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Alexander <143108850+nv-apoddubny@users.noreply.github.com>
…erf_improvement_internal
Mayankm96
reviewed
Aug 1, 2024
Mayankm96
reviewed
Aug 1, 2024
Mayankm96
reviewed
Aug 1, 2024
Mayankm96
reviewed
Aug 1, 2024
source/extensions/omni.isaac.lab/test/terrains/check_terrain_importer.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 1, 2024
Mayankm96
reviewed
Aug 1, 2024
Mayankm96
changed the title
6 tasks
Dhoeller19
approved these changes
Aug 2, 2024
jsmith-bdai
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
LGTM, thanks for adding!
CC: @hhansen-bdai as this might relate to device selection efforts (specifically the .kit files)
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…isaac-sim#759) # Description - Removes unneeded extensions from headless app file - Limits CPU threads when running multi-GPU training to minimize thread context switching - Apply multi GPU renderer setting to avoid unnecessary GPU context initialization - Decreases 8k SH startup time on 8 GPUs from > 5 min to 1 min - Adds benchmarking scripts ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Alexander <143108850+nv-apoddubny@users.noreply.github.com> Co-authored-by: David Hoeller <dhoeller@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there