Adds video recording to the play scripts in RL workflows #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
Jul 31, 2024
Mayankm96
reviewed
Jul 31, 2024
Mayankm96
reviewed
Jul 31, 2024
|
Thanks for the review! I have resolved all comments. It's worth noting that the change on default recording path from |
Mayankm96
approved these changes
Aug 3, 2024
Mayankm96
changed the title
BREAKING CHANGE: `video` -> `video/train`
j3soon
force-pushed
the
feat/play-video-record
branch
from
6285772 to
81c3cfd
Compare
|
Just rebased this branch on |
Dhoeller19
approved these changes
Aug 5, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description This MR enables users to easily record videos from trained checkpoints, which is useful for sanity checks or creating promotional videos for research papers. Fixes: isaac-sim#130 ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR enables users to easily record videos from trained checkpoints, which is useful for sanity checks or creating promotional videos for research papers.
Fixes: #130
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there