Adds flag to preserve joint order inside JointActionCfg action term
#787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
JointActionCfg action term
Mayankm96
approved these changes
Aug 6, 2024
Dhoeller19
approved these changes
Aug 6, 2024
|
I have just updated the two files changelog and extension.toml |
Mayankm96
reviewed
Aug 6, 2024
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
approved these changes
Aug 6, 2024
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
|
@xav-nal The checks are failing for the pre-commit. Could you please run the command |
|
When I run the commands listed here (https://isaac-sim.github.io/IsaacLab/source/refs/contributing.html) to contribute to the documentation, everything works: I see my change updated in the documentation. However I do not see any additional files to include in the pull request. I assume this is normal. Regarding the point "I have added tests that prove my fix is effective or that my feature works," I must admit that I am not sure how to do do that. |
|
Thanks a lot @xav-nal! |
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…isaac-sim#787) # Description Adds the attribute `preserve_order` in `JointActionCfg`, to choose whether joint-related actions should keep the same order as how the `joint_names` are listed in the config. Fixes isaac-sim#786 ## Type of change - New feature ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's config/extension.toml file - [x] I have added my name to the CONTRIBUTORS.md or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new feature to allow the option to maintain the order of joint names in the action configuration when calling mdp.JointPositionActionCfg for example.
In action_cfg.py
In joints_actions.py
Fixes #786
Type of change
Screenshots
"action_cfg.py"
Before:
After
In "joints_actions.py"
Before:
After:
Checklist
pre-commitchecks with./isaaclab.sh --format