Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to resume training from a checkpoint with rl_games #797

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

sizsJEon
Copy link
Contributor

@sizsJEon sizsJEon commented Aug 7, 2024

Description

The rl_games train.py script did not include the checkpoint and sigma. (it was none)
I have added these features and verified their operation.

Fixes # (issue)

  • New feature (non-breaking change which adds functionality)

Screenshots

train from scratch
Screenshot from 2024-08-07 13-06-48

got 84 reward pth at 300 epoch
Screenshot from 2024-08-07 13-06-48

train (retrain) with pth file and sigma
Screenshot from 2024-08-07 13-09-22
Screenshot from 2024-08-07 13-10-32

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@sizsJEon sizsJEon changed the title Add checkpoint and sigma for rl_games Add checkpoint and sigma for rl_games train.py Aug 7, 2024
@Dhoeller19 Dhoeller19 added the enhancement New feature or request label Aug 7, 2024
@Dhoeller19
Copy link
Collaborator

@sizsJEon, thanks for your contribution!
The formatter is currently failing, could you please resolve the issue?

sizsJEon and others added 2 commits August 7, 2024 17:38
Co-authored-by: David Hoeller <dhoeller@nvidia.com>
Signed-off-by: sizsJEon <sizs2002@kookmin.ac.kr>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
@Dhoeller19 Dhoeller19 changed the title Add checkpoint and sigma for rl_games train.py Adds the ability to resume training from a checkpoint with rl_games Aug 7, 2024
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
@Dhoeller19 Dhoeller19 merged commit 1b8e2c0 into isaac-sim:main Aug 12, 2024
1 of 2 checks passed
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
…saac-sim#797)

# Description

The rl_games train.py script did not include the checkpoint and sigma.
(it was none)
I have added these features and verified their operation.

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants