-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds configurable modifiers to observation manager #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
Aug 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/modifiers/modifier.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 15, 2024
Mayankm96
reviewed
Aug 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/modifiers/modifier_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/modifiers/modifier.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/modifiers/modifier.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 15, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/modifiers/modifier.py
Outdated
Show resolved
Hide resolved
jsmith-bdai
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for adding test, new docs and a useful feature 🚀
source/extensions/omni.isaac.lab/omni/isaac/lab/utils/modifiers/modifier.py
Outdated
Show resolved
Hide resolved
Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com> Signed-off-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com>
Mayankm96
reviewed
Aug 16, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
changed the title
Adds configurable modifiers to observations
Adds configurable modifiers to observation manager
Aug 16, 2024
Mayankm96
approved these changes
Aug 17, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description The goal of this PR is to introduce expanded functionality to observation corruption/realism. This is done by introducing the concept of configurable modifiers. This creates an architecture that can apply a list of custom modifiers to observation data giving flexibility to order of operations. Existing modifiers for clip, scale, bias, and noise can be used. This does so without changing the current functionality. This PR also includes two new modifiers that are stateful (i.e. output is dependent on previous state) that utilize a Callable class. They are a `DigitalFilter` and an `Integrator`. Summary of Additions: - Adds `ModifierCfg` and `Modifier` - Adds example modifiers functions for bias, scale, clip, noise - Adds example modifiers classes: DigitalFilter, Integrator - Adds functionality to `ObservationManager` to prepare and handle modifiers of observation data - Adds unit tests for modifiers in test_modifiers.py - Adds test to test_observation_manager.py to test integration with modifiers ## Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com> Co-authored-by: Mayank Mittal <mittalma@leggedrobotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to introduce expanded functionality to observation corruption/realism. This is done by introducing the concept of configurable modifiers. This creates an architecture that can apply a list of custom modifiers to observation data giving flexibility to order of operations. Existing modifiers for clip, scale, bias, and noise can be used. This does so without changing the current functionality. This PR also includes two new modifiers that are stateful (i.e. output is dependent on previous state) that utilize a Callable class. They are a
DigitalFilter
and anIntegrator
.Summary of Additions:
ModifierCfg
andModifier
ObservationManager
to prepare and handle modifiers of observation dataType of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there