Disables default viewport when headless but cameras are enabled #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
Aug 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/simulation_context.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/app/app_launcher.py
Outdated
Show resolved
Hide resolved
Mayankm96
changed the title
|
Renamed the title to make it clear which scenarios are being referred to. Also adding @hhansen-bdai as a reviewer to check as well. |
Mayankm96
approved these changes
Aug 22, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…c-sim#851) # Description When cameras are enabled, a default render product always gets created for the viewport, which brings additional overhead for rendering the viewport at each step. However, when running in headless mode, we may not need to render the viewport if we are not recording or livestreaming. This change disables viewport rendering in the headless cases where recording and livestreaming are not required. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When cameras are enabled, a default render product always gets created for the viewport, which brings additional overhead for rendering the viewport at each step. However, when running in headless mode, we may not need to render the viewport if we are not recording or livestreaming.
This change disables viewport rendering in the headless cases where recording and livestreaming are not required.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there