Expands on articulation test for multiple instances and devices #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtigue-bdai
approved these changes
Aug 26, 2024
source/extensions/omni.isaac.lab/test/assets/test_articulation.py
Outdated
Show resolved
Hide resolved
jsmith-bdai
commented
Aug 26, 2024
source/extensions/omni.isaac.lab/test/assets/test_articulation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com> Signed-off-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com>
pascal-roth
added
enhancement
|
@jsmith-bdai if you look at the AWS log, the test does not run properly: |
Ah good catch, I had committed the suggested changes, but haven't re-run yet - will fix. |
|
@Dhoeller19 @Mayankm96 @kellyguo11 can one of you review this one? It has passed its checks ✔️ |
Mayankm96
approved these changes
Sep 6, 2024
Mayankm96
changed the title
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…c-sim#872) # Description Expands upon `test_articulation.py` to test with mulitple robots and on both CPU / GPU. Fixes isaac-sim#861 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expands upon
test_articulation.pyto test with mulitple robots and on both CPU / GPU.Fixes #861
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there