Updates camera docs with world units and introduces new test for intrinsics #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
…sim/IsaacLab into feature/cam-init-intrinsic-matrix
pascal-roth
requested review from
Mayankm96,
jsmith-bdai,
Dhoeller19 and
kellyguo11
as code owners
pascal-roth
added
enhancement
kellyguo11
approved these changes
Aug 28, 2024
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/ray_caster_camera_cfg.py
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/sensors/sensors_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/spawners/sensors/sensors_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/test/sensors/test_ray_caster_camera.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
jsmith-bdai
approved these changes
Aug 30, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/patterns/patterns_cfg.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sensors/ray_caster/ray_caster_camera_cfg.py
Show resolved
Hide resolved
Co-authored-by: James Smith <142246516+jsmith-bdai@users.noreply.github.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
Dhoeller19
approved these changes
Sep 3, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…insics (isaac-sim#886) # Description Updates the camera docs with SI units and implants a new test to check that the intrinsic are set correctly for the raycaster camera. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the camera docs with SI units and implants a new test to check that the intrinsic are set correctly for the raycaster camera.
This PR should be merged after #617
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there