Defaults the gym video recorder fps to match episode decimation #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozhanozen
requested review from
jsmith-bdai,
Dhoeller19 and
Mayankm96
as code owners
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Outdated
Show resolved
Hide resolved
Mayankm96
changed the title
I have added. Also, I have changed the code comment slightly to this: |
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Aug 29, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/direct_rl_env.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Özhan Özen <41010165+ozhanozen@users.noreply.github.com>
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Özhan Özen <41010165+ozhanozen@users.noreply.github.com>
Mayankm96
approved these changes
Aug 29, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…c-sim#894) Sets the "render_fps" metadata used by the gym.wrappers.RecordVideo such that, if it is used, the produced video will have the correct episode length (i.e., the environment in the video will play at the correct speed). The correct render_fps should be equal to `1 / (self.cfg.decimation * self.cfg.sim.dt)` which I integrated to the init function of the ManagerBasedRLEnv. This seems to work well. Fixes isaac-sim#892 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots <img width="1048" alt="Screenshot 2024-08-28 at 18 10 30" src="https://github.com/user-attachments/assets/d4fd8482-fbbc-48fa-8890-6a75a3fd99dc"> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the "render_fps" metadata used by the gym.wrappers.RecordVideo such that, if it is used, the produced video will have the correct episode length (i.e., the environment in the video will play at the correct speed).
The correct render_fps should be equal to
1 / (self.cfg.decimation * self.cfg.sim.dt)which I integrated to the init function of the ManagerBasedRLEnv. This seems to work well.Fixes #892
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there