Fixes support for classmethod when defining a configclass
#901
+59
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
requested review from
Dhoeller19,
jsmith-bdai and
kellyguo11
as code owners
jsmith-bdai
approved these changes
Aug 29, 2024
|
Thank you for the quick review! I checked and there are no other occurrences :) |
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…m#901) # Description Previously, the configclass instance did not properly parse classmethods. For instance, the following would fail: ```python from __future__ import annotations """Launch Isaac Sim Simulator first.""" from omni.isaac.lab.app import AppLauncher # launch omniverse app app_launcher = AppLauncher(headless=True) """Rest everything follows.""" from omni.isaac.lab.utils.configclass import configclass @configclass class DummyClass: a: int = 5 def instance_method(self): print("Value of a: ", self.a) @classmethod def class_method(cls, value: int) -> DummyClass: return cls(a=value) cfg = DummyClass() # check all methods are callable cfg.instance_method() new_cfg1 = cfg.class_method(20) # create the same config instance using class method new_cfg2 = DummyClass.class_method(20) ``` This MR fixes the checks to make sure class-methods remain bound to the class and do not become instance variables. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the configclass instance did not properly parse classmethods. For instance, the following would fail:
This MR fixes the checks to make sure class-methods remain bound to the class and do not become instance variables.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there