Adapts A and D button bindings in the keyboard device #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binded to -y axis(was +y), this is now in accordance with both keyboard device documentation and right hand rule.
zoctipus
requested review from
Dhoeller19,
Mayankm96,
jsmith-bdai and
kellyguo11
as code owners
Mayankm96
changed the title
Mayankm96
reviewed
Sep 5, 2024
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
approved these changes
Sep 5, 2024
|
Thanks for fix. Looks good. Can you please also adapt the |
|
Done! Thanks for reviewing XD |
Mayankm96
approved these changes
Sep 5, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description While developing some teleoperation methods, I discovered that the keyboard y-axis was moving in a non-intuitive direction. It turned out that the +ve and -ve y-axis are bound to keys (D, A) instead of (A, D). This MR fixes the issue in both keyboard device documentation instructions to follow the right-hand rule. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots  ## Checklist - [X] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [X] I have made corresponding changes to the documentation - [X] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [X] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [X] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While developing some teleoperation methods, I discovered that the keyboard y-axis was moving in a non-intuitive direction. It turned out that the +ve and -ve y-axis are bound to keys (D, A) instead of (A, D). This MR fixes the issue in both keyboard device documentation instructions to follow the right-hand rule.
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there