-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets native livestream extensions to Isaac Sim 4.1-4.0 defaults #954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should read the extension versions from that file so that we don't need to modify the settings here for different Isaac Sim versions. But this can be its own MR. If the current fix works for 4.1, we can move ahead with it.
…c-sim#954) # Description Streaming does not work for `isaaclab --livestream 1` using streaming client 103.1.1. This change sets the streaming client extension versions to the defaults in isaac-sim-4.1.0/apps/omni.isaac.sim.headless.native.kit Fixes isaac-sim#949 ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Description
Streaming does not work for
isaaclab --livestream 1
using streaming client 103.1.1.This change sets the streaming client extension versions to the defaults in isaac-sim-4.1.0/apps/omni.isaac.sim.headless.native.kit
Fixes #949
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there