Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets native livestream extensions to Isaac Sim 4.1-4.0 defaults #954

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jtigue-bdai
Copy link
Collaborator

Description

Streaming does not work for isaaclab --livestream 1 using streaming client 103.1.1.

This change sets the streaming client extension versions to the defaults in isaac-sim-4.1.0/apps/omni.isaac.sim.headless.native.kit

Fixes #949

Type of change

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jtigue-bdai jtigue-bdai marked this pull request as ready for review September 6, 2024 19:34
@Mayankm96 Mayankm96 changed the title Set livestream 1 stream extensions to isaac 4.1-4.0 defaults Sets native livestream extensions to Isaac Sim 4.1-4.0 defaults Sep 6, 2024
@Mayankm96 Mayankm96 added the bug Something isn't working label Sep 6, 2024
Copy link
Collaborator

@hhansen-bdai hhansen-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@Mayankm96 Mayankm96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should read the extension versions from that file so that we don't need to modify the settings here for different Isaac Sim versions. But this can be its own MR. If the current fix works for 4.1, we can move ahead with it.

@Dhoeller19 Dhoeller19 merged commit 710f64d into main Sep 10, 2024
2 of 3 checks passed
@Dhoeller19 Dhoeller19 deleted the fix/streaming_client_103.1.1_capatible branch September 10, 2024 14:48
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
…c-sim#954)

# Description

Streaming does not work for `isaaclab --livestream 1` using streaming
client 103.1.1.

This change sets the streaming client extension versions to the defaults
in isaac-sim-4.1.0/apps/omni.isaac.sim.headless.native.kit

Fixes isaac-sim#949 

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Isaac lab streaming not working with client 103.1.1
5 participants