Adds support for MJCF converter #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqqwan
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11 and
Mayankm96
as code owners
kellyguo11
reviewed
Sep 7, 2024
Mayankm96
reviewed
Sep 8, 2024
Mayankm96
reviewed
Sep 8, 2024
Mayankm96
reviewed
Sep 8, 2024
Mayankm96
reviewed
Sep 8, 2024
Mayankm96
reviewed
Sep 8, 2024
Mayankm96
previously requested changes
Sep 8, 2024
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
kellyguo11
approved these changes
Sep 10, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description Added command-line MJCF conversion script and corresponding support and test files. - `convert_mjcf.py` in `standalone/tools/` - `mjcf_converter.py` and `mjcf_converter_cfg.py` in `extensions/omni.isaac.lab/omni/isaac/lab/sim/converters/` - tests and corresponding tutorial update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Signed-off-by: Kelly Guo <kellyguo123@hotmail.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added command-line MJCF conversion script and corresponding support and test files.
convert_mjcf.pyinstandalone/tools/mjcf_converter.pyandmjcf_converter_cfg.pyinextensions/omni.isaac.lab/omni/isaac/lab/sim/converters/Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there