Fixes venv and conda pip installation on windows #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyguo11
requested review from
hhansen-bdai,
Dhoeller19 and
Mayankm96
as code owners
Mayankm96
approved these changes
Sep 11, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description The current windows installation does not support pip installation of isaac sim in venv as it only checks whether a conda environment is enabled or assumes that a symlink to isaac sim is used. This change adds support to check for system python when isaac sim is installed via pip. In addition, isaac sim variables at conda environment startup should only be assigned if isaac sim is installed from binary. This change addresses the need for when pip installation of isaac sim is used in conda. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current windows installation does not support pip installation of isaac sim in venv as it only checks whether a conda environment is enabled or assumes that a symlink to isaac sim is used. This change adds support to check for system python when isaac sim is installed via pip. In addition, isaac sim variables at conda environment startup should only be assigned if isaac sim is installed from binary. This change addresses the need for when pip installation of isaac sim is used in conda.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there