use fs.lchown rather than fs.chown and thereby fix #14 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the symlinks problem isaacs#3 while not causing the TOCTOU vulnerability isaacs#14 The [patch in libuv 1.21.0](https://github.com/libuv/libuv/releases/tag/v1.21.0) that undeprecates `fs.lchown` [has been incorporated in nodejs Version 10.6.0](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#2018-07-04-version-1060-current-targos). So I specified the minimum nodejs version in `package.json` with the `engine` key: https://docs.npmjs.com/files/package.json#engines
afeld
reviewed
Aug 10, 2018
| @@ -19,5 +19,6 @@ | |||
| "scripts": { | |||
| "test": "tap test/*.js" | |||
| }, | |||
| "license": "ISC" | |||
| "license": "ISC", | |||
| "engines": { "node" : ">=10.6.0" } | |||
There was a problem hiding this comment.
You'll need to change the .travis.yml to match.
There was a problem hiding this comment.
Maybe update that list to match the maintained Node versions?
There was a problem hiding this comment.
The job exceeded the maximum time limit for jobs, and has been terminated.
no wonder, it decided to build nodejs 10.6.0 from source !
added 4 commits
August 10, 2018 17:36
see: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions in the process: - update that list to match the maintained Node versions see: https://github.com/nodejs/Release#release-schedule - remove the constraint on the npm version (I dont' see why the default npm would not work)
|
Ok now the tests are running on nodejs 10.8 and we get several errors, of 3 types:
the very same 30 tests are failing on master; see: #16 |
|
Since this seems to get no attention from the project maintainer, is there a way to help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the symlinks problem #3 while not causing the TOCTOU vulnerability #14
The patch in libuv 1.21.0 that undeprecates
fs.lchownhas been incorporated in nodejs Version 10.6.0.So I specified the minimum nodejs version in
package.jsonwith theenginekey: https://docs.npmjs.com/files/package.json#engines