Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fs.lchown rather than fs.chown and thereby fix #14 #15

Closed
wants to merge 5 commits into from
Closed

use fs.lchown rather than fs.chown and thereby fix #14 #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bd6861
use fs.lchown rather than fs.chown and thereby fix #14
Aug 10, 2018
fbc1254
update travis to match the supported nodejs version
Aug 10, 2018
0cdeb99
update travis to use a docker image with node 10.8 preinstalled
Aug 11, 2018
ddf0a82
fix docker/travis config
Aug 11, 2018
63409f9
docker unknown shorthand flag -w
Aug 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions chownr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,12 @@ function chownr (p, uid, gid, cb) {
, errState = null
children.forEach(function (child) {
var pathChild = path.resolve(p, child);
fs.lstat(pathChild, function(er, stats) {
if (er)
return cb(er)
if (!stats.isSymbolicLink())
chownr(pathChild, uid, gid, then)
else
then()
})
chownr(pathChild, uid, gid, then)
})
function then (er) {
if (errState) return
if (er) return cb(errState = er)
if (-- len === 0) return fs.chown(p, uid, gid, cb)
if (-- len === 0) return fs.lchown(p, uid, gid, cb)
}
})
}
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@
"scripts": {
"test": "tap test/*.js"
},
"license": "ISC"
"license": "ISC",
"engines": { "node" : ">=10.6.0" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to change the .travis.yml to match.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update that list to match the maintained Node versions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job exceeded the maximum time limit for jobs, and has been terminated.

no wonder, it decided to build nodejs 10.6.0 from source !

}