Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing redundant checks #8

Merged
merged 3 commits into from
Nov 20, 2015
Merged

Removing redundant checks #8

merged 3 commits into from
Nov 20, 2015

Conversation

thefourtheye
Copy link
Contributor

  1. When we are comparing the objectToString values, isObject check is not
    necessary. So removing those checks. Refer util: removing redundant checks in is* functions nodejs/node#2179
  2. Buffer.isArray need not be run in another function, as it is a static function.
  3. Including compatible checks for versions older then ES5, for Arrays. Refer fix for es<5 not having Array.isArray() #3

@thefourtheye
Removing redundant checks
0b47fda 
1. When we are comparing the `objectToString` values, `isObject` check is not
   necessary. So removing those checks.

2. `Buffer.isArray` and `Array.isArray` need not be run in another function, as
   they are static functions.
@thefourtheye
Incorporating < ES5 compatible check for Arrays
60e7df2 
Refer: isaacs#3
@thefourtheye
Fixing typo
67c1cad
@thefourtheye thefourtheye mentioned this pull request Aug 11, 2015
Closed
@thefourtheye
Copy link
Contributor Author

Bump!

@thefourtheye
Copy link
Contributor Author

@isaacs Bump!

@isaacs isaacs merged commit 67c1cad into isaacs:master Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thefourtheye @isaacs