util: removing redundant checks in is* functions #2179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Object.prototype.toString is used to determine the type, we don't have to explicitly check for other types. This patch removes the redundant checks like that.
|
LGTM |
1 similar comment
|
LGTM |
|
Ya LGTM, I don't remember why I didn't do this when I was looking at |
brendanashworth
added
the
util
|
CI before landing: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/158/ |
|
@Fishrock123 The CI failures are not related to this change :-) |
|
@Fishrock123 Can this be landed? |
|
Yep, was LGTM if the CI was good. (it is) |
thefourtheye
added a commit
that referenced
this pull request
Jul 21, 2015
When Object.prototype.toString is used to determine the type, we don't have to explicitly check for other types. This patch removes the redundant checks like that. PR-URL: #2179 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thanks folks. Landed at 6391f4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Object.prototype.toString is used to determine the type, we don't
have to explicitly check for other types. This patch removes the
redundant checks like that.