Support adapter type inheritance #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, Thank you for your contribution! |
|
Any plans on when this will be released to pub.dev? |
Probably in a few days, will update you when published. |
|
I'm also eagerly awaiting this! |
|
Can someone review #928? I want to merge it before next release but also worry if it breaks compatibility. In theory it shouldn't but real world is complicated.. |
roubachof
added a commit
to roubachof/hive
that referenced
this pull request
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let P be a super type and C its subtype.
In the current implementation,
TypeRegistryImpl.findAdapterForValuealways picks the first match for an adapter of C. This behavior is okay. However, when two type adapters, one for P and one for C got registered (first P and then C), thenTypeRegistryImpl.findAdapterForValuewill always return the adapter for P and never the more specific one for C.This PR adjusts the behavior to first return an adapter that matches the runtime type of
value. When no such adapter exists, then it falls back to how the current implementation behaves.It also adds some tests for the new implementation.
Closes #880, closes #893 and maybe #821.
I am happy to make any adjustments required to (hopefully) merge this thing fast.