Support UTF-8 keys #928
Merged
Support UTF-8 keys #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themisir
force-pushed
the
themisir/utf8_keys
branch
from
8c4895c
to
da5e674
Compare
|
This looks good to me. Functionality works as expected (stored and retrieved entries with keys containing vietnamese letters). Tested with one of my finished apps that uses Hive and everything works as it did previously. |
|
Thanks @alexobviously 😇 |
|
Hello @themisir , Shouldn't this check be removed? Can't use |
|
Giving a PR |
This PR adds utf8 support for the keys not the box names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using unicode keys using UTF-8 encoding. There will be no backwards compatibility issue because ASCII is compatible with UTF-8 encoding.
Closes #159, #717, #412, #84, #37