s1_orbit: return S1A/S1B when parsing filename #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes isce-framework#103 to get the right orbit file. Currently we are returning "A" or "B" as a "sensor_id", then searching if the orbit file has that identifier (the single letter, which all orbit files have). This 1. changes the parser to return the full S1A/S1B, 2. calls it the "mission_id" to match the language in the product spec https://sentinels.copernicus.eu/documents/247904/351187/Copernicus_Sentinels_POD_Service_File_Format_Specification 3. does further simplficication and cleanup of logic to make pylance/flake8 errors go away
vbrancat
reviewed
Feb 27, 2023
src/s1reader/s1_orbit.py
Outdated
| end_time, 'AUX_POEORB') | ||
| # If orbit dict is empty, find restituted orbits | ||
| if orbit_dict is None: | ||
| orbit_dict = get_orbit_dict(sensor_id, start_time, | ||
| orbit_dict = get_orbit_dict(mission_id, start_time, | ||
| end_time, 'AUX_RESORB') | ||
| # Download orbit file | ||
| orbit_file = os.path.join(orbit_dir, orbit_dict["orbit_name"] + '.EOF') |
There was a problem hiding this comment.
I find more compact to use fstring
vbrancat
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #103 to get the right orbit file.
Currently we are returning "A" or "B" as a "sensor_id", then searching if the orbit file has that identifier (the single letter, which all orbit files have).
This 1. changes the parser to return the full S1A/S1B, 2. calls it the "mission_id" to match the language in the product spec https://sentinels.copernicus.eu/documents/247904/351187/Copernicus_Sentinels_POD_Service_File_Format_Specification
The movement of function locations is to group similar functions together (
parse_safe_filenameandget_file_name_tokenswere >100 lines apart before)