New/pybind #6
Merged
New/pybind #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Expose PointCloud class in Python + std::vector<Eigen::Vector3d> handling
Now support Hybrid search.
from 38s per iteration to 0.15m per iteration. 250x speedup.
+ Change many C++ style functions to python style functions in python binding + Split code into multiple files * Minor bug fix regarding header guards
Have not been fully tested yet
+ Python test code + copy and deep copy for many classes
I have decided to pivot away from the default conversion between eigen and numpy provided by pybind11. Instead, custom numerical types are introduced. Benefit: Its syntax is more correct. x = Vector3dVector(…) x[0] is now the reference (instead of a copy), and you can change it with: x[0][0] = y Drawbacks: Cannot use […] directly, must wrap with e.g. Vector3d([…]) But I think it is syntax more correct. In the long run it is better.
See this PR: pybind/pybind11#610
+ PinholeCameraIntrinsic + Readxxx and Writexxx functions * Move copy and deepcopy into template functions * Bug fixes * 💄
See test_py3d_camera() for details. We add a test that combines 5 RGB-D images with a given trajectory.
Closed
akashsharma02
pushed a commit
to akashsharma02/Open3D
that referenced
this pull request
May 20, 2020
Fix for tinyobjloader submodule
yxlao
added a commit
that referenced
this pull request
Dec 10, 2020
3 tasks
Woodman3
added a commit
to Woodman3/Open3D
that referenced
this pull request
Jan 22, 2025
…org#6) * [Feat] add conv op * [Doc] add comment * [fix] add contigous(not compile) --------- Signed-off-by: Woodman3 <1025760745@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed #5
Current using an unstable development version 2.1.dev0, with my own patches.
In the future, should transfer to a stable version like 2.1.