Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed usage of TensorFlow Status API #6091

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

NobuoTsukamoto
Copy link
Contributor

@NobuoTsukamoto NobuoTsukamoto commented Apr 19, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

In TensorFlow 2.11 and later, tsensorflow::Status::OK() has been removed.
This causes build errors.
Changing to tensorflow::Status() will maintain compatibility with previous versions and fix build errors.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

If not corrected, the following build error will occur with TensorFlow v2.12.

error: 'OK' is not a member of 'tsl::Status'
  150 |             return Status::OK();

This change is Reviewable

@update-docs
Copy link

update-docs bot commented Apr 19, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from benjaminum June 1, 2023 17:52
@ssheorey
Copy link
Member

ssheorey commented Jun 1, 2023

Thanks, @NobuoTsukamoto.
@benjaminum This change works with the current Tensorflow 2.8 as well.

@ssheorey ssheorey merged commit 7ef6754 into isl-org:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants