-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(user-profile): Remove migration worker and make user profile strict #14791
Conversation
WalkthroughThe recent updates to the user-profile service focus on simplifying configurations, removing deprecated worker-related functionalities, and enhancing the flexibility of data models and DTOs. These changes include dropping unused environment variables, refactoring service setup, updating model attribute types, and modifying DTO properties to allow optional and nullable values. Additionally, a database migration script has been introduced to drop an obsolete table. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (26)
- apps/services/user-profile/infra/service-portal-api.ts (3 hunks)
- apps/services/user-profile/migrations/20240513221742-remove-migration-table.js (1 hunks)
- apps/services/user-profile/project.json (2 hunks)
- apps/services/user-profile/src/app/user-profile/dto/confirmEmailDto.ts (1 hunks)
- apps/services/user-profile/src/app/user-profile/dto/confirmSmsDto.ts (1 hunks)
- apps/services/user-profile/src/app/user-profile/emailVerification.model.ts (3 hunks)
- apps/services/user-profile/src/app/user-profile/smsVerification.model.ts (3 hunks)
- apps/services/user-profile/src/app/user-profile/userDeviceTokens.model.ts (2 hunks)
- apps/services/user-profile/src/app/user-profile/userProfile.controller.ts (4 hunks)
- apps/services/user-profile/src/app/user-profile/userProfile.service.ts (2 hunks)
- apps/services/user-profile/src/app/user-profile/userToken.controller.ts (1 hunks)
- apps/services/user-profile/src/app/utils/format-phone-number.ts (1 hunks)
- apps/services/user-profile/src/app/v2/dto/actor-profile.dto.ts (2 hunks)
- apps/services/user-profile/src/app/v2/dto/islyklar-upsert.dto.ts (1 hunks)
- apps/services/user-profile/src/app/v2/dto/post-nudge.dto.ts (1 hunks)
- apps/services/user-profile/src/app/v2/dto/user-profile.dto.ts (1 hunks)
- apps/services/user-profile/src/app/v2/user-profile.module.ts (1 hunks)
- apps/services/user-profile/src/app/v2/user-profile.service.ts (9 hunks)
- apps/services/user-profile/src/config.ts (2 hunks)
- apps/services/user-profile/src/environments/environment.ts (3 hunks)
- apps/services/user-profile/src/main.ts (1 hunks)
- apps/services/user-profile/tsconfig.json (1 hunks)
- charts/islandis/values.dev.yaml (2 hunks)
- charts/islandis/values.prod.yaml (2 hunks)
- charts/islandis/values.staging.yaml (2 hunks)
- infra/src/uber-charts/islandis.ts (5 hunks)
Files skipped from review due to trivial changes (7)
- apps/services/user-profile/migrations/20240513221742-remove-migration-table.js
- apps/services/user-profile/src/app/utils/format-phone-number.ts
- apps/services/user-profile/src/environments/environment.ts
- apps/services/user-profile/tsconfig.json
- charts/islandis/values.dev.yaml
- charts/islandis/values.prod.yaml
- charts/islandis/values.staging.yaml
Additional Context Used
Path-based Instructions (18)
apps/services/user-profile/src/app/v2/dto/islyklar-upsert.dto.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/v2/dto/post-nudge.dto.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/dto/confirmEmailDto.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/dto/confirmSmsDto.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/main.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/config.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/userDeviceTokens.model.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/v2/dto/actor-profile.dto.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/v2/dto/user-profile.dto.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/emailVerification.model.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/smsVerification.model.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/v2/user-profile.module.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/userToken.controller.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/userProfile.service.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/infra/service-portal-api.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/project.json (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/user-profile/userProfile.controller.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/services/user-profile/src/app/v2/user-profile.service.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (38)
apps/services/user-profile/src/app/v2/dto/islyklar-upsert.dto.ts (1)
2-2
: EnsurenationalId
is always provided.The non-null assertion operator (
!
) indicates thatnationalId
is always expected to be provided. Ensure that this property is correctly validated and assigned in the codebase to avoid runtime errors.apps/services/user-profile/src/app/v2/dto/post-nudge.dto.ts (1)
9-9
: EnsurenudgeType
is always provided.The non-null assertion operator (
!
) indicates thatnudgeType
is always expected to be provided. Ensure that this property is correctly validated and assigned in the codebase to avoid runtime errors.apps/services/user-profile/src/app/user-profile/dto/confirmEmailDto.ts (1)
7-8
: Ensurehash
is correctly handled when optional.The
hash
property is now optional. Ensure that the code handling this property correctly accounts for the possibility of it beingundefined
.apps/services/user-profile/src/app/user-profile/dto/confirmSmsDto.ts (1)
7-8
: Ensurecode
is correctly handled when optional.The
code
property is now optional. Ensure that the code handling this property correctly accounts for the possibility of it beingundefined
.apps/services/user-profile/src/main.ts (1)
1-13
: EnsureopenApi
and versioning are correctly configured.The
openApi
configuration and versioning have been added to the bootstrap configuration. Ensure that these configurations are correctly set up and tested to avoid runtime issues.apps/services/user-profile/src/config.ts (1)
Line range hint
1-27
: Ensure removal ofworkerProcessPageSize
is consistent.The
workerProcessPageSize
field has been removed from the schema definition. Ensure that this field is no longer used or referenced in the codebase to avoid runtime errors.apps/services/user-profile/src/app/user-profile/userDeviceTokens.model.ts (1)
34-40
: EnsureCreationOptional
properties are correctly handled.The properties
id
,created
, andmodified
have been changed to useCreationOptional
. Ensure that these properties are correctly handled during model creation and updates to avoid runtime errors.apps/services/user-profile/src/app/v2/dto/actor-profile.dto.ts (2)
35-35
: EnsureThe
null
.
48-48
: Ensurelocale
is correctly handled when nullable.The
locale
property is now nullable. Ensure that the code handling this property correctly accounts for the possibility of it beingnull
.apps/services/user-profile/src/app/v2/dto/user-profile.dto.ts (4)
16-16
: Ensure that thenationalId
property is always provided when creating or updating aUserProfileDto
instance.
21-21
: Thenull
. Ensure that the rest of the codebase handles this property correctly when it isnull
.
26-26
: ThemobilePhoneNumber
property is now optional and can benull
. Ensure that the rest of the codebase handles this property correctly when it isnull
.
31-31
: Thelocale
property is now optional and can benull
. Ensure that the rest of the codebase handles this property correctly when it isnull
.apps/services/user-profile/src/app/user-profile/emailVerification.model.ts (6)
10-14
: The import ofCreationOptional
andInferAttributes
,InferCreationAttributes
fromsequelize
is appropriate for making some properties optional during creation.
25-28
: TheEmailVerification
class now extendsModel<InferAttributes<EmailVerification>, InferCreationAttributes<EmailVerification>>
, which allows for more flexible attribute definitions.
36-36
: Theid
property is now optional during creation, which is suitable for auto-generated IDs.
40-40
: Thecreated
property is now optional during creation, which is appropriate for auto-generated timestamps.
44-44
: Themodified
property is now optional during creation, which is appropriate for auto-generated timestamps.
58-58
: Theconfirmed
property is now optional during creation, which is suitable for default values.apps/services/user-profile/src/app/user-profile/smsVerification.model.ts (6)
10-14
: The import ofCreationOptional
andInferAttributes
,InferCreationAttributes
fromsequelize
is appropriate for making some properties optional during creation.
25-28
: TheSmsVerification
class now extendsModel<InferAttributes<SmsVerification>, InferCreationAttributes<SmsVerification>>
, which allows for more flexible attribute definitions.
36-36
: Theid
property is now optional during creation, which is suitable for auto-generated IDs.
40-40
: Thecreated
property is now optional during creation, which is appropriate for auto-generated timestamps.
44-44
: Themodified
property is now optional during creation, which is appropriate for auto-generated timestamps.
64-64
: Theconfirmed
property is now optional during creation, which is suitable for default values.apps/services/user-profile/src/app/v2/user-profile.module.ts (1)
35-35
: The use of the spread operator to consolidate theIslykillApiModule
configuration is a good practice for cleaner and more maintainable code.apps/services/user-profile/src/app/user-profile/userToken.controller.ts (1)
49-49
: ThefindOneByNationalId
method now returnsPromise<UserProfile | null>
, which is a more accurate representation of the possible return values. Ensure that the rest of the codebase handles thenull
case correctly.apps/services/user-profile/src/app/user-profile/userProfile.service.ts (1)
70-70
: The error handling in theaddDeviceToken
method now throws aBadRequestException
with the error details. This is a good practice for providing more informative error messages.apps/services/user-profile/infra/service-portal-api.ts (1)
Line range hint
1-99
: The removal of worker-related configurations and the update of environment variables are appropriate given the completion of the migration job. Ensure that all references to the removed configurations are also cleaned up in the codebase.apps/services/user-profile/project.json (1)
94-94
: The removal of the worker configuration fromproject.json
is appropriate given the completion of the migration job. Ensure that all references to the worker configuration are also cleaned up in the codebase.infra/src/uber-charts/islandis.ts (1)
13-13
: Ensure theservicePortalApiSetup
import is necessary and correctly used in the file.#!/bin/bash # Description: Verify the usage of `servicePortalApiSetup` in the file. # Test: Search for the usage of `servicePortalApiSetup`. Expect: At least one usage. rg --type js 'servicePortalApiSetup' infra/src/uber-charts/islandis.tsapps/services/user-profile/src/app/user-profile/userProfile.controller.ts (2)
51-51
: Ensure theLocale
import is necessary and correctly used in the file.#!/bin/bash # Description: Verify the usage of `Locale` in the file. # Test: Search for the usage of `Locale`. Expect: At least one usage. rg --type ts 'Locale' apps/services/user-profile/src/app/user-profile/userProfile.controller.ts
116-116
: Ensure the default locale assignment toLocale.ICELANDIC
is intended and correct.#!/bin/bash # Description: Verify the default locale assignment in the `getActorLocale` method. # Test: Check the usage of `Locale.ICELANDIC`. Expect: Correct default assignment. rg --type ts 'Locale.ICELANDIC' apps/services/user-profile/src/app/user-profile/userProfile.controller.tsapps/services/user-profile/src/app/v2/user-profile.service.ts (5)
76-77
: Ensure the default values formobilePhoneNumberVerified
andemailVerified
are intended and correct.#!/bin/bash # Description: Verify the default values for `mobilePhoneNumberVerified` and `emailVerified` in the `findAllBySearchTerm` method. # Test: Check the usage of default values. Expect: Correct default assignment. rg --type ts 'mobilePhoneNumberVerified' apps/services/user-profile/src/app/v2/user-profile.service.ts rg --type ts 'emailVerified' apps/services/user-profile/src/app/v2/user-profile.service.ts
161-162
: Ensure the non-null assertion operators (!
) formobilePhoneNumber
are safe and intended.#!/bin/bash # Description: Verify the usage of non-null assertion operators in the `patch` method. # Test: Check the usage of non-null assertion operators. Expect: Safe and intended usage. rg --type ts 'email!' apps/services/user-profile/src/app/v2/user-profile.service.ts rg --type ts 'mobilePhoneNumber!' apps/services/user-profile/src/app/v2/user-profile.service.tsAlso applies to: 183-184
220-220
: Ensure the conditional assignments foremailStatus
andmobileStatus
are correct and intended.#!/bin/bash # Description: Verify the conditional assignments for `emailStatus` and `mobileStatus` in the `patch` method. # Test: Check the usage of conditional assignments. Expect: Correct and intended usage. rg --type ts 'emailStatus' apps/services/user-profile/src/app/v2/user-profile.service.ts rg --type ts 'mobileStatus' apps/services/user-profile/src/app/v2/user-profile.service.tsAlso applies to: 229-229
503-506
: Ensure the handling of optional fields in thehasUnverifiedOrNotDefinedData
method is correct and intended.#!/bin/bash # Description: Verify the handling of optional fields in the `hasUnverifiedOrNotDefinedData` method. # Test: Check the usage of optional fields. Expect: Correct and intended handling. rg --type ts 'hasUnverifiedOrNotDefinedData' apps/services/user-profile/src/app/v2/user-profile.service.ts
555-556
: Ensure the handling of optional fields in thefilterByClientTypeAndRestrictionDate
method is correct and intended.#!/bin/bash # Description: Verify the handling of optional fields in the `filterByClientTypeAndRestrictionDate` method. # Test: Check the usage of optional fields. Expect: Correct and intended handling. rg --type ts 'filterByClientTypeAndRestrictionDate' apps/services/user-profile/src/app/v2/user-profile.service.tsAlso applies to: 565-580
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR's had a 15-day siesta. Lost its spark, did it? It's making an exit in 5 days unless the stale label disappears. |
This PR closed its doors. Sat around for a day after the stale tag, then reckoned it's not worth the fuss. |
74cb917
to
de5a8d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14791 +/- ##
==========================================
- Coverage 37.02% 37.01% -0.02%
==========================================
Files 6424 6424
Lines 130995 130947 -48
Branches 37481 37461 -20
==========================================
- Hits 48505 48467 -38
+ Misses 82490 82480 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 6 Total Test Services: 0 Failed, 6 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
* fix(inheritance-report): EFS touch ups (#15161) * fix(inheritance-report): EFS touch ups * done texts * tweaks * texts * removed unused files --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(license-service): less contentful (#15088) * feat: less contentful * chore:use reaodnly * chore: remove unnecessary * chore: console logs --------- Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(user-profile): Remove migration worker and make user profile strict (#14791) * Remove worker and make user profile strict * Fix dependant type errors. --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(j-s): Actor title in indictment confirmation pt2 (#15149) * Convert px to pts * Use Pts instead of pxls * Refactoring * Revert change * Tweeks to COA * Tweeks to COA * Smaller COA * Cleanup * Make title optional * Don't use Beygla for confirmation * Move confirmation stamp from pxls to pts * Remove debug code * Fix lint --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(driving-instructor-registrations): Add tabs for B and BE license (#14609) * add tabs for B and BE license * set no-cache on query * fetch license category specific book * only display tabs for teachers with multiple rights * add feature flag * remove console logs * address comments --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix: formstepper formatMessage * chore: simplify slightly * fix(ojoi): Datepicker default date (#15177) --------- Co-authored-by: albinagu <47886428+albinagu@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Þorkell Máni Þorkelsson <wowthorkell@gmail.com> Co-authored-by: Þorkell Máni Þorkelsson <mani@hugsmidjan.is> Co-authored-by: Sævar Már Atlason <54210288+saevarma@users.noreply.github.com> Co-authored-by: Ívar Oddsson <ivaroddsson@gmail.com> Co-authored-by: juni-haukur <158475136+juni-haukur@users.noreply.github.com> Co-authored-by: Þórður H <thordur@hugsmidjan.is>
…rict (#14791) * Remove worker and make user profile strict * Fix dependant type errors. --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…rict (#14791) * Remove worker and make user profile strict * Fix dependant type errors. --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Corresponding Helm cleanup PR
https://github.com/island-is/helm/pull/785
What
Why
Screenshots / Gifs
N/A
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores
Documentation