Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(j-s): Remove the robot-api app #16950

Merged
merged 4 commits into from
Nov 20, 2024
Merged

chore(j-s): Remove the robot-api app #16950

merged 4 commits into from
Nov 20, 2024

Conversation

oddsson
Copy link
Member

@oddsson oddsson commented Nov 20, 2024

Remove the robot-api app

Asana

What

Remove the robot-api app as it's not being used.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Expanded instructions for implementing feature flags in the application.
  • Bug Fixes

    • Adjusted health check paths for the judicial-system-web service.
  • Chores

    • Removed the judicial-system-robot-api component from deployment configurations across all environments.
    • Updated resource limits and HPA settings for remaining services in the judicial system.

@oddsson oddsson requested review from a team as code owners November 20, 2024 10:28
Copy link
Contributor

coderabbitai bot commented Nov 20, 2024

Walkthrough

This pull request includes significant changes to the judicial system application, primarily involving the removal of the "Robot API" and its related configurations. The README.md file has been updated to eliminate the Robot API section and add detailed instructions for implementing feature flags. Additionally, multiple configuration files related to the Robot API have been deleted, indicating the component's decommissioning. Changes also include updates to deployment configurations across various environments, adjusting resource limits and health check paths for remaining components.

Changes

File Path Change Summary
apps/judicial-system/README.md Removed "Robot API" section; added detailed instructions for implementing feature flags.
apps/judicial-system/robot-api/.eslintrc.json Deleted ESLint configuration file.
apps/judicial-system/robot-api/esbuild.json Deleted esbuild configuration file.
apps/judicial-system/robot-api/infra/judicial-system-xrd-robot-api.ts Deleted service setup function for Robot API.
apps/judicial-system/robot-api/jest.config.ts Deleted Jest configuration file.
apps/judicial-system/robot-api/project.json Deleted project configuration file for Robot API.
apps/judicial-system/robot-api/src/app/app.config.ts Deleted application configuration setup.
apps/judicial-system/robot-api/src/app/app.controller.ts Deleted AppController class handling HTTP requests.
apps/judicial-system/robot-api/src/app/app.module.ts Deleted main application module for Robot API.
apps/judicial-system/robot-api/src/app/app.service.ts Deleted AppService class providing service functionality.
apps/judicial-system/robot-api/src/app/index.ts Deleted index file exporting AppModule.
apps/judicial-system/robot-api/src/buildOpenApi.ts Deleted OpenAPI generation functionality.
apps/judicial-system/robot-api/src/main.ts Deleted entry point for the Robot API application.
apps/judicial-system/robot-api/src/openApi.ts Deleted OpenAPI configuration.
apps/judicial-system/robot-api/tsconfig.app.json Deleted TypeScript configuration file for the application.
apps/judicial-system/robot-api/tsconfig.json Deleted TypeScript configuration file.
apps/judicial-system/robot-api/tsconfig.spec.json Deleted TypeScript configuration file for tests.
charts/judicial-system/values.dev.yaml Removed judicial-system-robot-api section; added TIME_TO_LIVE_MINUTES to judicial-system-scheduler.
charts/judicial-system/values.prod.yaml Removed judicial-system-robot-api section; updated configurations for other components.
charts/judicial-system/values.staging.yaml Removed judicial-system-robot-api section; updated TIME_TO_LIVE_MINUTES and health check path.
infra/src/uber-charts/judicial-system.ts Removed import and usage of jsRobotApiSetup; updated Services export.

Possibly related PRs

Suggested labels

automerge

Suggested reviewers

  • thorkellmani
  • lodmfjord

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra LGTM

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.41%. Comparing base (c4f2ff4) to head (9cee822).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16950      +/-   ##
==========================================
- Coverage   36.41%   36.41%   -0.01%     
==========================================
  Files        6898     6898              
  Lines      144883   144883              
  Branches    41410    41410              
==========================================
- Hits        52755    52753       -2     
- Misses      92128    92130       +2     
Flag Coverage Δ
air-discount-scheme-backend 54.08% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.34% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 37.08% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.58% <ø> (ø)
api-domains-criminal-record 47.56% <ø> (ø)
api-domains-driving-license 44.50% <ø> (ø)
api-domains-education 30.57% <ø> (ø)
api-domains-health-insurance 34.43% <ø> (ø)
api-domains-mortgage-certificate 34.74% <ø> (ø)
api-domains-payment-schedule 41.31% <ø> (ø)
application-api-files 62.42% <ø> (ø)
application-core 71.11% <ø> (ø)
application-system-api 41.02% <ø> (ø)
application-template-api-modules 27.73% <ø> (ø)
application-templates-accident-notification 28.98% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.87% <ø> (ø)
application-templates-driving-license 18.14% <ø> (ø)
application-templates-estate 12.14% <ø> (ø)
application-templates-example-payment 24.80% <ø> (ø)
application-templates-financial-aid 15.77% <ø> (ø)
application-templates-general-petition 23.07% <ø> (ø)
application-templates-inheritance-report 6.52% <ø> (ø)
application-templates-marriage-conditions 15.04% <ø> (ø)
application-templates-mortgage-certificate 43.42% <ø> (+0.05%) ⬆️
application-templates-parental-leave 29.86% <ø> (ø)
application-types 6.57% <ø> (ø)
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.57% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 31.10% <ø> (ø)
auth-react 21.85% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.28% <ø> (ø)
clients-driving-license-book 43.50% <ø> (ø)
clients-financial-statements-inao 49.06% <ø> (ø)
clients-license-client 1.26% <ø> (ø)
clients-middlewares 73.33% <ø> (+0.08%) ⬆️
clients-regulations 42.36% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.23% <ø> (ø)
clients-zendesk 50.61% <ø> (ø)
cms 0.41% <ø> (ø)
cms-translations 38.91% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.14% <ø> (ø)
contentful-apps 4.69% <ø> (ø)
dokobit-signing 62.76% <ø> (ø)
download-service 44.16% <ø> (ø)
email-service 60.57% <ø> (ø)
feature-flags 90.62% <ø> (ø)
file-storage 45.80% <ø> (ø)
financial-aid-backend 51.29% <ø> (ø)
financial-aid-shared 17.81% <ø> (ø)
icelandic-names-registry-backend 54.34% <ø> (ø)
infra-nest-server 48.37% <ø> (ø)
infra-tracing 43.24% <ø> (ø)
island-ui-core 28.88% <ø> (ø)
judicial-system-api 19.86% <ø> (ø)
judicial-system-audit-trail 68.86% <ø> (ø)
judicial-system-backend 55.60% <ø> (ø)
judicial-system-formatters 79.35% <ø> (ø)
judicial-system-message 67.05% <ø> (ø)
judicial-system-message-handler 48.08% <ø> (ø)
judicial-system-scheduler 70.79% <ø> (ø)
judicial-system-types 43.31% <ø> (ø)
judicial-system-web 27.16% <ø> (ø)
license-api 42.65% <ø> (+0.05%) ⬆️
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 68.79% <ø> (ø)
nest-audit 68.20% <ø> (ø)
nest-aws 53.04% <ø> (ø)
nest-config 78.00% <ø> (ø)
nest-core 43.54% <ø> (ø)
nest-feature-flags 51.09% <ø> (ø)
nest-problem 45.82% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.71% <ø> (ø)
nova-sms 62.09% <ø> (ø)
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 15.89% <ø> (ø)
reference-backend 49.74% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.51% <ø> (ø)
services-auth-delegation-api 57.51% <ø> (-0.01%) ⬇️
services-auth-ids-api 52.09% <ø> (-0.02%) ⬇️
services-auth-personal-representative 45.63% <ø> (ø)
services-auth-personal-representative-public 41.68% <ø> (-0.09%) ⬇️
services-auth-public-api 48.91% <ø> (ø)
services-documents 60.81% <ø> (ø)
services-endorsements-api 53.21% <ø> (ø)
services-sessions 65.50% <ø> (+0.04%) ⬆️
services-university-gateway 49.31% <ø> (-0.06%) ⬇️
services-user-notification 46.77% <ø> (ø)
services-user-profile 61.89% <ø> (ø)
shared-components 26.90% <ø> (ø)
shared-form-fields 31.26% <ø> (ø)
shared-mocking 60.89% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (ø)
skilavottord-ws 24.14% <ø> (ø)
web 1.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f2ff4...9cee822. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-island-is
Copy link

Datadog Report

All test runs 7b31529 🔗

99 Total Test Services: 0 Failed, 97 Passed
🔻 Test Sessions change in coverage: 4 decreased, 1 increased (+0.1%), 195 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 82 0 34.08s N/A Link
air-discount-scheme-web 0 0 0 2 0 9.36s N/A Link
api 0 0 0 4 0 2.97s N/A Link
api-catalogue-services 0 0 0 23 0 12.86s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 20.24s N/A Link
api-domains-assets 0 0 0 3 0 12.86s N/A Link
api-domains-auth-admin 0 0 0 18 0 14.4s N/A Link
api-domains-communications 0 0 0 5 0 37.8s N/A Link
api-domains-criminal-record 0 0 0 5 0 11.02s N/A Link
api-domains-driving-license 0 0 0 23 0 34.04s N/A Link

🔻 Code Coverage Decreases vs Default Branch (4)

  • nest-feature-flags - jest 56.41% (-0.46%) - Details
  • services-university-gateway - jest 45.1% (-0.03%) - Details
  • license-api - jest 33.91% (-0.01%) - Details
  • application-template-api-modules - jest 30.13% (-0.01%) - Details

@oddsson oddsson added the automerge Merge this PR as soon as all checks pass label Nov 20, 2024
@kodiakhq kodiakhq bot merged commit c2d4dfb into main Nov 20, 2024
267 checks passed
@kodiakhq kodiakhq bot deleted the j-s/remove-robot-api branch November 20, 2024 13:04
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2024
6 tasks
AndesKrrrrrrrrrrr pushed a commit that referenced this pull request Nov 22, 2024
* Remove robot-api app

* Remove robot-api app

* chore: charts update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this pull request Nov 22, 2024
* Remove robot-api app

* Remove robot-api app

* chore: charts update dirty files

---------

Co-authored-by: Ívar Oddsson <ivaroddsson@gmail.com>
Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jonnigs pushed a commit that referenced this pull request Nov 26, 2024
* Remove robot-api app

* Remove robot-api app

* chore: charts update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants