feat(j-s): Public defender staff overview after review #14848
Conversation
WalkthroughThe changes involve enhancing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…m/island-is/island.is into j-s/public-defender-reviewed-case
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (16)
- apps/judicial-system/api/src/app/modules/defendant/dto/updateDefendant.input.ts (1 hunks)
- apps/judicial-system/api/src/app/modules/defendant/models/defendant.model.ts (1 hunks)
- apps/judicial-system/backend/migrations/20240514111505-update-defendant.js (1 hunks)
- apps/judicial-system/backend/src/app/modules/defendant/defendant.controller.ts (2 hunks)
- apps/judicial-system/backend/src/app/modules/defendant/dto/updateDefendant.dto.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts (1 hunks)
- apps/judicial-system/web/src/components/FormProvider/case.graphql (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.css.ts (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCard.css.ts (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx (3 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (2 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCardIndictment.strings.ts (1 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.strings.ts (1 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (6 hunks)
- apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1 hunks)
Files skipped from review due to trivial changes (3)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.css.ts
- apps/judicial-system/web/src/components/InfoCard/InfoCardIndictment.strings.ts
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.strings.ts
Additional Context Used
Path-based Instructions (13)
apps/judicial-system/backend/migrations/20240514111505-update-defendant.js (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/InfoCard/InfoCard.css.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/defendant/dto/updateDefendant.dto.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/defendant/models/defendant.model.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/api/src/app/modules/defendant/dto/updateDefendant.input.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/defendant/defendant.controller.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/FormProvider/case.graphql (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Learnings (2)
apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1)
User: unakb PR: island-is/island.is#14712 File: apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/IndictmentOverview.tsx:0-0 Timestamp: 2024-05-06T18:09:27.876Z Learning: The judicial system application uses a toaster notification system to handle errors globally.apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (1)
User: oddsson PR: island-is/island.is#14673 File: apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx:79-79 Timestamp: 2024-05-06T23:16:04.892Z Learning: The implementation of `mapIndictmentCaseStateToTagVariant` in `TagCaseState.tsx`, which maps only `CaseState.ACCEPTED` to a specific tag and defaults others to an "unknown" status, is intentional as per the application's requirements.
Additional comments not posted (18)
apps/judicial-system/backend/migrations/20240514111505-update-defendant.js (2)
3-16: The migration script for adding thehas_viewed_verdictcolumn is correctly implemented with transaction support.
18-24: The rollback script for removing thehas_viewed_verdictcolumn is correctly implemented with transaction support.apps/judicial-system/web/src/components/InfoCard/InfoCard.css.ts (1)
Line range hint
1-24: The CSS styles inInfoCard.css.tsare well-structured and make good use of theme variables for consistency.apps/judicial-system/backend/src/app/modules/defendant/dto/updateDefendant.dto.ts (1)
76-80: The addition of thehasViewedVerdictfield inUpdateDefendantDtois correctly implemented with appropriate validation and API documentation decorators.apps/judicial-system/api/src/app/modules/defendant/models/defendant.model.ts (1)
65-67: The addition of thehasViewedVerdictfield in theDefendantGraphQL model is correctly implemented with the appropriate nullable field decorator.apps/judicial-system/api/src/app/modules/defendant/dto/updateDefendant.input.ts (1)
85-89: The addition of thehasViewedVerdictfield inUpdateDefendantInputis correctly implemented with the appropriate nullable field decorator.apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts (1)
146-152: The addition of thehasViewedVerdictfield in theDefendantSequelize model is correctly implemented with the appropriate column definition and API documentation.apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx (1)
16-97: TheDefendantInfocomponent is well-implemented, making effective use of props to conditionally render defendant details and actions.apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (1)
Line range hint
16-93: TheInfoCardClosedIndictmentcomponent is well-implemented, effectively integrating with other components and props to display detailed case information.apps/judicial-system/backend/src/app/modules/defendant/defendant.controller.ts (2)
30-30: EnsurepublicProsecutorStaffRulecorrectly defines the intended permissions for public prosecutor staff.Verification successful
Ensure
publicProsecutorStaffRulecorrectly defines the intended permissions for public prosecutor staff.The
publicProsecutorStaffRuleis defined as allowing public prosecutor staff to perform any action, which seems appropriate for the intended permissions.
- Definition found in
apps/judicial-system/backend/src/app/guards/rolesRules.ts:// Allows public prosecutor staff to perform any action export const publicProsecutorStaffRule: RolesRule = UserRole.PUBLIC_PROSECUTOR_STAFFScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the permissions set by `publicProsecutorStaffRule`. # Test: Search for the rule definition and usage. Expect: Correct permission settings. rg --type typescript $'publicProsecutorStaffRule'Length of output: 83
Script:
#!/bin/bash # Description: Verify the permissions set by `publicProsecutorStaffRule`. # Test: Search for the rule definition and usage. Expect: Correct permission settings. rg --type ts 'publicProsecutorStaffRule'Length of output: 1298
Script:
#!/bin/bash # Description: Extract the definition of `publicProsecutorStaffRule` to verify its permissions. # Test: Locate and display the definition of `publicProsecutorStaffRule`. rg --type ts --context 5 'publicProsecutorStaffRule' apps/judicial-system/backend/src/app/guards/rolesRules.tsLength of output: 354
75-75: EnsurepublicProsecutorStaffRulecorrectly defines the intended permissions for public prosecutor staff in the update context.Verification successful
Ensure
publicProsecutorStaffRulecorrectly defines the intended permissions for public prosecutor staff in the update context.The
publicProsecutorStaffRuleis defined as allowing public prosecutor staff to perform any action:
apps/judicial-system/backend/src/app/guards/rolesRules.ts// Allows public prosecutor staff to perform any action export const publicProsecutorStaffRule: RolesRule = UserRole.PUBLIC_PROSECUTOR_STAFFThis definition aligns with the intended permissions for public prosecutor staff in the update context.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the permissions set by `publicProsecutorStaffRule` in the update context. # Test: Search for the rule definition and usage. Expect: Correct permission settings. rg --type typescript $'publicProsecutorStaffRule'Length of output: 83
Script:
#!/bin/bash # Description: Verify the permissions set by `publicProsecutorStaffRule` in the update context. # Test: Search for the rule definition and usage. Expect: Correct permission settings. rg --type ts 'publicProsecutorStaffRule'Length of output: 1298
Script:
#!/bin/bash # Description: Extract the definition of `publicProsecutorStaffRule` to verify its permissions. # Test: Extract the definition from `rolesRules.ts`. rg --type ts --context 5 'publicProsecutorStaffRule' apps/judicial-system/backend/src/app/guards/rolesRules.tsLength of output: 354
apps/judicial-system/web/src/components/FormProvider/case.graphql (1)
26-26: Ensure the GraphQL schema and resolver are updated to handle thehasViewedVerdictfield correctly.apps/judicial-system/web/src/routes/Shared/IndictmentOverview/IndictmentOverview.tsx (1)
27-27: The updated import path forReviewDecisionlooks correct. Ensure that all references to this component are updated accordingly.apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx (3)
10-13: The new imports forDefendantActionButtonandDefendantInfoare appropriate for the refactoring of theInfoCardcomponent.
37-41: The addition ofdefendantActionButtonto thePropsinterface enhances the functionality of theInfoCardcomponent, allowing for dynamic interactions.
123-129: The updated rendering logic to includeDefendantInfoanddefendantActionButtonimproves the functionality and user interaction of theInfoCardcomponent.apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (2)
1-13: The new imports and hooks enhance the functionality and interactivity of theOverviewcomponent.
133-148: The updated rendering logic to includeInfoCardClosedIndictmentwithdefendantActionButtonimproves the functionality and user interaction of theOverviewcomponent.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14848 +/- ##
==========================================
- Coverage 36.97% 36.97% -0.01%
==========================================
Files 6329 6331 +2
Lines 129050 129100 +50
Branches 36828 36843 +15
==========================================
+ Hits 47716 47731 +15
- Misses 81334 81369 +35 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 36 Total Test Services: 0 Failed, 35 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (4) |
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (12)
- apps/judicial-system/api/src/app/modules/defendant/dto/updateDefendant.input.ts (1 hunks)
- apps/judicial-system/api/src/app/modules/defendant/models/defendant.model.ts (1 hunks)
- apps/judicial-system/backend/migrations/20240514111505-update-defendant.js (1 hunks)
- apps/judicial-system/backend/src/app/modules/defendant/dto/updateDefendant.dto.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/defendant/test/defendantController/updateRolesRules.spec.ts (2 hunks)
- apps/judicial-system/web/src/components/FormProvider/case.graphql (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.strings.ts (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx (3 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx (2 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (6 hunks)
Files skipped from review due to trivial changes (1)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.strings.ts
Files skipped from review as they are similar to previous changes (9)
- apps/judicial-system/api/src/app/modules/defendant/dto/updateDefendant.input.ts
- apps/judicial-system/api/src/app/modules/defendant/models/defendant.model.ts
- apps/judicial-system/backend/migrations/20240514111505-update-defendant.js
- apps/judicial-system/backend/src/app/modules/defendant/dto/updateDefendant.dto.ts
- apps/judicial-system/backend/src/app/modules/defendant/models/defendant.model.ts
- apps/judicial-system/web/src/components/FormProvider/case.graphql
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx
- apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx
- apps/judicial-system/web/src/components/InfoCard/InfoCardClosedIndictment.tsx
Additional Context Used
GitHub Check Runs (1)
linting (judicial-system-api,judicial-system-web) success (13)
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx: [warning] 11-11:
'defendant' is defined but never used. Allowed unused vars must match /^_[a-zA-Z0-9]*$/u
Path-based Instructions (2)
apps/judicial-system/backend/src/app/modules/defendant/test/defendantController/updateRolesRules.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Learnings (1)
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (1)
User: oddsson PR: island-is/island.is#14673 File: apps/judicial-system/web/src/routes/PublicProsecutor/Tables/CasesForReview.tsx:79-79 Timestamp: 2024-05-06T23:16:04.892Z Learning: The implementation of `mapIndictmentCaseStateToTagVariant` in `TagCaseState.tsx`, which maps only `CaseState.ACCEPTED` to a specific tag and defaults others to an "unknown" status, is intentional as per the application's requirements.
Additional comments not posted (10)
apps/judicial-system/backend/src/app/modules/defendant/test/defendantController/updateRolesRules.spec.ts (2)
7-7: AddedpublicProsecutorStaffRuleto the import list.This ensures that the new rule is available for use in the test cases.
23-29: Updated test case to reflect the addition ofpublicProsecutorStaffRule.The test now correctly checks for the presence of the new rule, ensuring that the
DefendantController's update method is properly secured for the additional role.apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (8)
1-1: Updated imports to include necessary hooks and utilities.This ensures that all necessary functionalities are available in the component.
8-13: ImportedisCompletedCaseand message definitions.These imports are crucial for the new functionality related to handling verdict views and displaying appropriate UI elements.
32-37: ImportedDefendanttype and utility hooks.These are essential for managing defendant data and interactions within the component.
40-40: Defined a new type for modal visibility states.This enhances the readability and maintainability of the state management related to modal dialogs.
Line range hint
47-87: Refactored state management and added new functionality for handling defendant verdict views.The changes are well-structured and align with the PR objectives to enhance the indictment overview functionality.
134-149: UpdatedInfoCardClosedIndictmentto handle conditional rendering based on case completion.This is a crucial update for displaying the correct UI elements based on the case state.
161-205: Enhanced UI logic for reviewer assignment and updated form footer handling.These changes improve the user experience by providing clearer options and feedback during the review process.
Line range hint
207-230: Added modals for different states to enhance user interaction.The modals provide clear, contextual information to the users, improving the overall usability of the system.
apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx
Outdated
Show resolved
Hide resolved
…m/island-is/island.is into j-s/public-defender-reviewed-case
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.strings.ts (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx (1 hunks)
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx (6 hunks)
Files skipped from review as they are similar to previous changes (3)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.strings.ts
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx
- apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1 hunks)
Additional Context Used
Path-based Instructions (1)
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (1)
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1)
31-31: Addition ofverdictViewDatetodefendantsaligns with the new feature to track when a verdict is viewed.Verification successful
The
verdictViewDatefield is well-integrated into the system, both in the frontend and backend components.
Overview.tsx: Formatting the date for the server and checking if theverdictViewDateis not null.DefendantInfo.tsx: Using theverdictViewDateto get appeal expiration information.- Backend models and DTOs: Defining the
verdictViewDatefield in the defendant model and update DTO.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of `verdictViewDate` in the frontend components. # Test: Search for the usage of `verdictViewDate` in TypeScript files to ensure it's properly integrated. rg --type ts $'verdictViewDate'Length of output: 925
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.css.ts (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx (1 hunks)
- apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx (3 hunks)
Files skipped from review due to trivial changes (1)
- apps/judicial-system/web/src/components/InfoCard/InfoCard.tsx
Files skipped from review as they are similar to previous changes (2)
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.css.ts
- apps/judicial-system/web/src/components/InfoCard/DefendantInfo/DefendantInfo.tsx
Ríksak - Skrifstofa - Yfirlitssíða eftir yfirlestur
What
Checklist:
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes