fix(j-s): Show verdict appeal date for defenders

[oddsson]

Show verdict appeal date for defenders

Asana

What

When the public prosecutors office marks that a ruling has been served a 28 day timer starts ticking. This timer indicates the time a defendants have to appeal the ruling. This timer was not being shown to defenders, but rather always said "The appeal deadline has not started".

Why

This was a bug

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Introduced a new field, verdictAppealDeadline, to the defendants' information in the Limited Access Case query, enhancing the details available for legal cases.

[coderabbitai]

Walkthrough

The changes in this pull request introduce a new field, verdictAppealDeadline, to the defendants object in the LimitedAccessCase GraphQL query. This addition complements existing fields without altering the overall structure of the query. The update allows for more detailed information regarding defendants in legal cases.

Changes

File Path	Change Summary
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql	Added verdictAppealDeadline field to defendants object in the LimitedAccessCase query.

Possibly related PRs

• feat(j-s): Public defender staff overview after review #14848: This PR modifies the DefendantInfo component, which includes details about defendants, similar to the changes made in the limitedAccessCase GraphQL query where new fields related to defendants are added.
• fix(j-s): Defender File Display #15821: This PR also modifies the limitedAccessCase GraphQL query by adding new fields, which is directly related to the changes made in the main PR that introduces the verdictAppealDeadline field.

Suggested labels

automerge

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6ce1b55 and 0383bb1.

📒 Files selected for processing (1)

• apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (1)

apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1)

38-38: LGTM: New field added correctly and aligns with PR objectives.

The addition of the verdictAppealDeadline field to the defendants object is correct and aligns well with the PR objectives. This new field will allow the system to display the correct appeal deadline for defendants, addressing the issue mentioned in the PR summary.

Observations:

1. The field is correctly placed within the defendants object.
2. The field name follows the camelCase naming convention used throughout the query.
3. This addition directly supports the PR's goal of showing the correct appeal deadline for defendants.
4. The change adheres to GraphQL best practices by extending the existing type without breaking changes.

To ensure this change is properly utilized, let's verify its usage in the codebase:

✅ Verification successful

✅ Verification Successful: verdictAppealDeadline field is correctly integrated.

The verdictAppealDeadline field has been successfully added to the GraphQL queries and is properly utilized within the codebase. It is present in both limitedAccessCase.graphql and case.graphql, and its usage is confirmed across relevant TypeScript/JavaScript files. This ensures consistency and alignment with the PR objectives of displaying the correct appeal deadlines for defendants.

• apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql
• apps/judicial-system/web/src/components/FormProvider/case.graphql
• Usage confirmed in DefendantInfo.tsx, DefendantInfo.spec.ts, and related transformer and model files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the usage of the new verdictAppealDeadline field

# Test: Search for verdictAppealDeadline in TypeScript/JavaScript files
echo "Searching for verdictAppealDeadline usage:"
rg --type-add 'frontend:*.{ts,tsx,js,jsx}' -t frontend 'verdictAppealDeadline'

# Test: Check if the GraphQL schema has been updated
echo "Checking if the GraphQL schema has been updated:"
rg --type graphql 'verdictAppealDeadline'

Length of output: 3641

---

Script:

#!/bin/bash
# Description: Re-verify the usage of the new verdictAppealDeadline field in GraphQL files

# Test: Search for verdictAppealDeadline in all GraphQL files
echo "Re-attempting to search for verdictAppealDeadline in GraphQL files without specifying file type:"
rg 'verdictAppealDeadline' --glob '*.graphql'

Length of output: 449

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.72%. Comparing base (919129f) to head (43b36ed).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16312      +/-   ##
==========================================
- Coverage   36.73%   36.72%   -0.02%     
==========================================
  Files        6804     6801       -3     
  Lines      140861   140002     -859     
  Branches    40118    39857     -261     
==========================================
- Hits        51751    51417     -334     
+ Misses      89110    88585     -525     

Flag	Coverage Δ
judicial-system-web	27.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 142 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919129f...43b36ed. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/show-verdict-appeal-date-defenders
Commit report: 382febe
Test service: judicial-system-web

✅ 0 Failed, 338 Passed, 0 Skipped, 1m 7.32s Total Time
➡️ Test Sessions change in coverage: 1 no change