Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(j-s): Defender File Display #15821

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix(j-s): Defender File Display #15821

merged 2 commits into from
Sep 2, 2024

Conversation

gudjong
Copy link
Member

@gudjong gudjong commented Aug 29, 2024

Defender File Display

Gagnaframlagning - Í skjalalista sér verjandi ekki nafn skjals og dagsetning skjals er röng

What

  • Shows user generated name and display date for additional files in defender case overview.

Why

  • Verified bug.

Screenshots / Gifs

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features
    • Enhanced the Limited Access Case query to include additional fields: userGeneratedFilename and displayDate, providing users with more detailed case information.

@gudjong gudjong requested a review from a team as a code owner August 29, 2024 19:34
Copy link
Contributor

coderabbitai bot commented Aug 29, 2024

Walkthrough

The changes involve the addition of two new fields, userGeneratedFilename and displayDate, to the LimitedAccessCase GraphQL query. These fields enhance the data structure returned by the query, allowing clients to access more detailed information regarding a case.

Changes

Files Change Summary
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql Added userGeneratedFilename and displayDate fields to the LimitedAccessCase query selection set.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues on the discussion post.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fccaa6d and f47addc.

Files selected for processing (1)
  • apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1 hunks)
Additional context used
Path-based instructions (1)
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (2)

17-17: LGTM!

The addition of the userGeneratedFilename field aligns with the PR objectives and enhances the data returned by the query.


18-18: LGTM!

The addition of the displayDate field aligns with the PR objectives and enhances the data returned by the query.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.93%. Comparing base (b74a253) to head (84045b1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15821   +/-   ##
=======================================
  Coverage   36.93%   36.93%           
=======================================
  Files        6680     6680           
  Lines      136450   136450           
  Branches    38742    38742           
=======================================
  Hits        50398    50398           
  Misses      86052    86052           
Flag Coverage Δ
judicial-system-web 28.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74a253...84045b1. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Aug 29, 2024

Datadog Report

Branch report: j-s/limited-access-file-fix
Commit report: 43bb1e9
Test service: judicial-system-web

✅ 0 Failed, 336 Passed, 0 Skipped, 1m 13.44s Total Time
➡️ Test Sessions change in coverage: 1 no change

@oddsson oddsson added the automerge Merge this PR as soon as all checks pass label Sep 2, 2024
@kodiakhq kodiakhq bot merged commit b1c86d5 into main Sep 2, 2024
30 checks passed
@kodiakhq kodiakhq bot deleted the j-s/limited-access-file-fix branch September 2, 2024 14:36
jonnigs pushed a commit that referenced this pull request Sep 12, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants