-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(j-s): Defender File Display #15821
Conversation
WalkthroughThe changes involve the addition of two new fields, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1 hunks)
Additional context used
Path-based instructions (1)
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (1)
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/judicial-system/web/src/components/FormProvider/limitedAccessCase.graphql (2)
17-17
: LGTM!The addition of the
userGeneratedFilename
field aligns with the PR objectives and enhances the data returned by the query.
18-18
: LGTM!The addition of the
displayDate
field aligns with the PR objectives and enhances the data returned by the query.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15821 +/- ##
=======================================
Coverage 36.93% 36.93%
=======================================
Files 6680 6680
Lines 136450 136450
Branches 38742 38742
=======================================
Hits 50398 50398
Misses 86052 86052
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 336 Passed, 0 Skipped, 1m 13.44s Total Time |
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Defender File Display
Gagnaframlagning - Í skjalalista sér verjandi ekki nafn skjals og dagsetning skjals er röng
What
Why
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
userGeneratedFilename
anddisplayDate
, providing users with more detailed case information.