feat(j-s): Add functionality to enable revoking appeal #17301
Conversation
WalkthroughThis pull request introduces a new feature for revoking appeals in the Judicial System web application. A new message key Changes
Sequence DiagramsequenceDiagram
participant User
participant Component
participant Server
User->>Component: Click "Revoke Appeal" button
Component->>Server: Send request to clear appeal date
Server-->>Component: Confirm date cleared
Component->>Component: Update UI to remove appeal date
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17301 +/- ##
=======================================
Coverage 35.68% 35.68%
=======================================
Files 6931 6931
Lines 148786 148794 +8
Branches 42510 42515 +5
=======================================
+ Hits 53092 53097 +5
- Misses 95694 95697 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 344 Passed, 0 Skipped, 55.12s Total Time |
oddsson
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts(1 hunks)apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx(7 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
📓 Learnings (2)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts (1)
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts:3-3
Timestamp: 2024-11-12T15:15:20.157Z
Learning: In `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts`, prefer not to add explicit TypeScript type definitions for the messages object.
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (3)
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:102-103
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In the TypeScript file `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, within the `handleSetDate` function, the else block is intentionally kept to handle an unlikely scenario and should not be removed, even if it appears unnecessary due to prior validation checks.
Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:84-105
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, the `setAndSendDefendantToServer` function handles errors internally, so additional error handling when calling it is not necessary.
Learnt from: oddsson
PR: island-is/island.is#16831
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:204-337
Timestamp: 2024-11-19T09:28:36.448Z
Learning: Buttons in this project are considered accessible as is, and adding additional ARIA attributes like `aria-label` and `aria-disabled` is not required unless specifically needed.
🔇 Additional comments (3)
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.strings.ts (1)
102-106: LGTM! The new message key follows the established pattern.
The revokeAppeal message key is well-structured with a clear namespace, appropriate default message in Icelandic, and a descriptive explanation of its usage.
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (2)
64-69: LGTM! Clear and efficient visibility control logic.
The shouldHideDatePickers variable effectively combines multiple conditions into a single, readable boolean expression, making the component's logic easier to follow.
219-241: LGTM! Animation variants are now more descriptive and consistent.
The renamed variants (verdictViewDateVariants and appealDateVariants) provide better clarity about their purpose, and the transition properties are well-defined for smooth animations.
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx
Show resolved
Hide resolved
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good! Tested and works well 🍰
Just one question about the components location in our project: Is there a reason why BlueBoxWithDate (apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx) is not co-located with the Overview component (apps/judicial-system/web/src/routes/PublicProsecutor/Indictments/Overview/Overview.tsx)? Asking because it seems to be specific to the public prosecutor component context 👀
You're right, this component is specific to the overview component. There is no specific reason for this component being where it is other than most components live in the components folder. |
oddsson
added
the
deprecated:automerge
Add functionality to enable revoking appeal
Asana
What
This PR implements functionality that enables staff at the public prosecutors office to revoke appeals by a defendant. In doing this, we discovered a bug in production that is fixed in this PR. The bug is that users can mark cases as appealed when the case has been sent to FMST and that should not be possible (the users should have to revoke the case from FMST first and then mark it as appealed).
This PR also tidies up a bit of animation code in the
BlueBoxWithDatecomponent. Mainly, we are renaming variables for clarity and making the animations a bit more smooth.Why
This feature is needed so that the staff at the PP office can do their jobs properly.
Screenshots / Gifs
Screen.Recording.2024-12-20.at.10.41.00.mov
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Refactor