fix: Add Service Portal to list of non-tracer apps #15022
Conversation
WalkthroughThe recent changes primarily involve the removal of the Changes
Sequence Diagram(s) (Beta)No sequence diagrams generated as the changes are primarily configuration adjustments and a minor addition to an existing function. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
peturgq
added
deprecated:automerge
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 1 Passed Test Services
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
infra/src/dsl/output-generators/map-to-helm-values.ts (4)
Line range hint
509-516: ReplaceforEachwithfor...offor better readability and modern JavaScript practices.- volumes.forEach((volume) => { + for (const volume of volumes) {
Line range hint
262-262: Simplify the computed expressions to enhance readability and maintainability.- env['REDIS_URL_NODE_01'] = serviceDef.redis.host ?? env1.redisHost + env['REDIS_URL_NODE_01'] = serviceDef.redis.host || env1.redisHostAlso applies to: 318-318, 319-319, 321-321, 327-327, 328-328, 334-334
Line range hint
163-163: Consider removing or properly handling non-null assertions to avoid potential runtime errors.Also applies to: 524-524, 528-528
Line range hint
231-231: Avoid using spread syntax on accumulators to improve performance.- return { ...acc, [`${ingressName}-alb`]: ingress } + acc[`${ingressName}-alb`] = ingress + return acc
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- charts/islandis/values.dev.yaml (1 hunks)
- charts/islandis/values.prod.yaml (1 hunks)
- charts/islandis/values.staging.yaml (1 hunks)
- infra/src/dsl/output-generators/map-to-helm-values.ts (1 hunks)
Files skipped from review due to trivial changes (3)
- charts/islandis/values.dev.yaml
- charts/islandis/values.prod.yaml
- charts/islandis/values.staging.yaml
Additional context used
Path-based instructions (1)
infra/src/dsl/output-generators/map-to-helm-values.ts (1)
Pattern
infra/src/dsl/**/*: "Confirm that the code adheres to the following:
- The clarity and expressiveness of the DSL syntax.
- Integration with Helm charts and Kubernetes resources.
- Documentation on how to use the DSL to create complex Helm values."
Biome
infra/src/dsl/output-generators/map-to-helm-values.ts
[error] 162-165: Prefer for...of instead of forEach.
[error] 163-163: Forbidden non-null assertion.
[error] 262-262: The computed expression can be simplified without the use of a string literal.
[error] 283-288: This else clause can be omitted because previous branches break early.
[error] 318-318: The computed expression can be simplified without the use of a string literal.
[error] 319-319: The computed expression can be simplified without the use of a string literal.
[error] 321-321: The computed expression can be simplified without the use of a string literal.
[error] 327-327: The computed expression can be simplified without the use of a string literal.
[error] 328-328: The computed expression can be simplified without the use of a string literal.
[error] 334-334: The computed expression can be simplified without the use of a string literal.
[error] 387-387: Invalid
typeofcomparison value: this expression is not a string literal
[error] 441-443: This else clause can be omitted because previous branches break early.
[error] 459-459: Do not use template literals if interpolation and special-character handling are not needed.
[error] 509-516: Prefer for...of instead of forEach.
[error] 524-524: Forbidden non-null assertion.
[error] 528-528: Forbidden non-null assertion.
[error] 1-9: All these imports are only used as types.
[error] 9-18: All these imports are only used as types.
[error] 18-19: All these imports are only used as types.
[error] 231-231: Avoid the use of spread (
...) syntax on accumulators.
Additional comments not posted (2)
infra/src/dsl/output-generators/map-to-helm-values.ts (2)
53-53: Addition of 'service-portal' to the non-tracer apps list is correctly implemented.
53-53: Ensure that the logic for excluding tracer initialization for non-tracer apps is thoroughly tested, especially with the new addition.
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* chore: Enable tracer only when its used (#15011) * chore: Enable tracer only when its used * rename to list * chore: nx format:write update dirty files * fix: typo * fix: tests --------- Co-authored-by: andes-it <builders@andes.is> * fix: Add Service Portal to list of non-tracer apps (#15022) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore: charts update dirty files --------- Co-authored-by: andes-it <builders@andes.is> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit
Configuration Changes
-r dd-trace/initoption for development, production, and staging environments, optimizing memory usage.New Features