fix(services-bff): Fix ingress for portals

[snaerth]

Fix ingress for portals

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Added service-portal and nginx-ingress-external namespaces to various services, enhancing access permissions.
• Bug Fixes
  • Updated health check paths for improved service monitoring.
• Chores
  • Adjusted Horizontal Pod Autoscaler settings for better scalability.
  • Modified resource limits and requests for several services to optimize performance.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications across multiple configuration files related to service setups in a Kubernetes environment. Key changes include the addition of the service-portal namespace in various services, updates to the grantNamespaces method to accept multiple arguments, and adjustments to health check paths and resource limits. These changes collectively enhance the service's operational scope and resource management without altering existing logic or control flows.

Changes

File Path	Change Summary
apps/api/infra/api.ts	Added 'service-portal' namespace to grantNamespaces method.
apps/services/bff/infra/admin-portal.infra.ts	Updated grantNamespaces() to accept two arguments: 'nginx-ingress-external' and 'identity-server'.
apps/services/bff/infra/my-pages-portal.infra.ts	Updated grantNamespaces() to accept two arguments: 'nginx-ingress-external' and 'identity-server'.
charts/islandis/values.dev.yaml	Added service-portal to grantNamespaces for api. Updated health check paths and HPA configurations.
charts/islandis/values.prod.yaml	Added service-portal to grantNamespaces in api, updated HPA settings, and ingress configurations.
charts/islandis/values.staging.yaml	Added service-portal to grantNamespaces, adjusted replica counts and resource limits.
charts/services/api/values.dev.yaml	Added service-portal to grantNamespaces.
charts/services/api/values.prod.yaml	Added service-portal to grantNamespaces, specified resource limits and requests.
charts/services/api/values.staging.yaml	Added service-portal to grantNamespaces.
charts/services/services-bff-portals-admin/values.dev.yaml	Added nginx-ingress-external to grantNamespaces.
charts/services/services-bff-portals-admin/values.prod.yaml	Added nginx-ingress-external to grantNamespaces.
charts/services/services-bff-portals-admin/values.staging.yaml	Added nginx-ingress-external to grantNamespaces.
charts/services/services-bff-portals-my-pages/values.dev.yaml	Added nginx-ingress-external to grantNamespaces.
charts/services/services-bff-portals-my-pages/values.prod.yaml	Added nginx-ingress-external to grantNamespaces.
charts/services/services-bff-portals-my-pages/values.staging.yaml	Added nginx-ingress-external to grantNamespaces.

Possibly related PRs

• fix: Add Service Portal to list of non-tracer apps #15022: This PR adds the Service Portal to the list of non-tracer applications, which may relate to the changes in the main PR that involve the serviceSetup function and namespace management.
• fix: added missing grant to auth ids api for user notification #16680: This PR adds a missing grant for the user notification namespace in the auth IDs API, which is relevant as it involves namespace grants similar to the changes in the main PR.
• fix(download-service): Grant namespace to bff admin portal #16728: This PR grants a namespace to the bff admin portal, which aligns with the main PR's focus on modifying namespace grants in the serviceSetup function.
• fix(services-bff): Fix bff proxy download service aws cognito #16719: This PR modifies the ingress configuration to disable global authentication, which may relate to the overall service setup changes in the main PR.
• fix(services-bff): Fix for agent protocol mismatch #16704: This PR addresses a protocol mismatch in the bff service, which may connect to the broader context of service configurations and namespace management in the main PR.

Suggested reviewers

• thordurhhh
• eirikurn

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 71774d0 and 2182ce0.

📒 Files selected for processing (15)

• apps/api/infra/api.ts (1 hunks)
• apps/services/bff/infra/admin-portal.infra.ts (1 hunks)
• apps/services/bff/infra/my-pages-portal.infra.ts (1 hunks)
• charts/islandis/values.dev.yaml (3 hunks)
• charts/islandis/values.prod.yaml (3 hunks)
• charts/islandis/values.staging.yaml (3 hunks)
• charts/services/api/values.dev.yaml (1 hunks)
• charts/services/api/values.prod.yaml (1 hunks)
• charts/services/api/values.staging.yaml (1 hunks)
• charts/services/services-bff-portals-admin/values.dev.yaml (1 hunks)
• charts/services/services-bff-portals-admin/values.prod.yaml (1 hunks)
• charts/services/services-bff-portals-admin/values.staging.yaml (1 hunks)
• charts/services/services-bff-portals-my-pages/values.dev.yaml (1 hunks)
• charts/services/services-bff-portals-my-pages/values.prod.yaml (1 hunks)
• charts/services/services-bff-portals-my-pages/values.staging.yaml (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[brynjarorng]

LGTM