feat(application-dld): Entry requirements in DP #15430
Conversation
WalkthroughThe updates introduce a new method Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Datadog ReportAll test runs ✅ 21 Total Test Services: 0 Failed, 20 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (5) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15430 +/- ##
==========================================
- Coverage 37.02% 36.94% -0.09%
==========================================
Files 6540 6541 +1
Lines 133700 133776 +76
Branches 38249 38260 +11
==========================================
- Hits 49498 49418 -80
- Misses 84202 84358 +156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 111 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (8)
- libs/api/domains/driving-license/src/lib/drivingLicense.service.ts (2 hunks)
- libs/api/domains/driving-license/src/lib/drivingLicense.type.ts (1 hunks)
- libs/application/template-api-modules/src/lib/modules/templates/driving-license-duplicate/driving-license-duplicate.service.ts (2 hunks)
- libs/application/templates/driving-license-duplicate/src/dataProviders/index.ts (2 hunks)
- libs/application/templates/driving-license-duplicate/src/forms/applicationSections/sectionDataProviders.ts (2 hunks)
- libs/application/templates/driving-license-duplicate/src/lib/drivingLicenseDuplicateTemplate.ts (2 hunks)
- libs/clients/driving-license/src/lib/drivingLicenseApi.types.ts (1 hunks)
- libs/clients/driving-license/src/v5/clientConfig.json (72 hunks)
Files not summarized due to errors (1)
- libs/clients/driving-license/src/v5/clientConfig.json: Error: Message exceeds token limit
Files skipped from review due to trivial changes (1)
- libs/application/templates/driving-license-duplicate/src/dataProviders/index.ts
Additional context used
Path-based instructions (7)
libs/application/templates/driving-license-duplicate/src/forms/applicationSections/sectionDataProviders.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/template-api-modules/src/lib/modules/templates/driving-license-duplicate/driving-license-duplicate.service.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/driving-license/src/lib/drivingLicense.type.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/clients/driving-license/src/lib/drivingLicenseApi.types.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/driving-license-duplicate/src/lib/drivingLicenseDuplicateTemplate.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/api/domains/driving-license/src/lib/drivingLicense.service.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/clients/driving-license/src/v5/clientConfig.json (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (32)
libs/application/templates/driving-license-duplicate/src/forms/applicationSections/sectionDataProviders.ts (2)
14-17: Confirm the addition ofDuplicateEligibilityApi.The
DuplicateEligibilityApihas been correctly imported and added to the list of data providers. Ensure that this API is correctly implemented and tested.
41-45: Ensure theDuplicateEligibilityApidata provider is functioning correctly.The
DuplicateEligibilityApihas been added to the list of data providers. Verify that this new data provider is functioning as expected and that it integrates smoothly with the rest of the application.libs/application/template-api-modules/src/lib/modules/templates/driving-license-duplicate/driving-license-duplicate.service.ts (1)
23-38: Confirm the addition of thecanGetNewDuplicatemethod.The
canGetNewDuplicatemethod has been correctly added to theDrivingLicenseDuplicateServiceclass. Ensure that this method is thoroughly tested and that the error handling logic is robust.libs/api/domains/driving-license/src/lib/drivingLicense.type.ts (1)
50-53: Confirm the addition of theDrivinglicenseDuplicateValidityStatusinterface.The
DrivinglicenseDuplicateValidityStatusinterface has been correctly added. Ensure that this interface is used consistently across the application and that it aligns with the expected response structure.libs/clients/driving-license/src/lib/drivingLicenseApi.types.ts (1)
41-41: Confirm the addition of thecommentsfield to theDriversLicenseinterface.The
commentsfield has been correctly added as an optional field. Ensure that this field is used appropriately and that any potential null values are handled correctly.libs/application/templates/driving-license-duplicate/src/lib/drivingLicenseDuplicateTemplate.ts (2)
28-31: Confirm the addition ofDuplicateEligibilityApito the dependencies.The
DuplicateEligibilityApihas been correctly added to the list of dependencies in theDrivingLicenseDuplicateTemplate. Ensure that this API is correctly implemented and tested.
127-127: Ensure theDuplicateEligibilityApidependency is functioning correctly.The
DuplicateEligibilityApihas been added to the list of dependencies. Verify that this new dependency is functioning as expected and that it integrates smoothly with the rest of the application.libs/clients/driving-license/src/v5/clientConfig.json (25)
6-9: Ensure contact information is up-to-date.The contact information provided should be verified for accuracy and updated if necessary.
22-24: LGTM!The schema definition for the
jwttokenheader parameter is correct.
31-34: LGTM!The schema definition for the
api-versionheader parameter is correct.
41-44: LGTM!The schema definition for the
api-versionquery parameter is correct.
82-94: LGTM!The schema definition for the
400 Bad Requestresponse is correct.
111-113: LGTM!The schema definition for the
applicationIdpath parameter is correct.
120-123: LGTM!The schema definition for the
api-versionheader parameter is correct.
130-133: LGTM!The schema definition for the
api-versionquery parameter is correct.
161-173: LGTM!The schema definition for the
400 Bad Requestresponse is correct.
190-203: LGTM!The schema definition for the
api-versionheader and query parameters is correct.
213-231: LGTM!The schema definition for the
200 Successresponse for a list of deprivations is correct.
249-262: LGTM!The schema definition for the
api-versionheader and query parameters is correct.
272-290: LGTM!The schema definition for the
200 Successresponse for a list of categories is correct.
308-321: LGTM!The schema definition for the
api-versionheader and query parameters is correct.
367-380: LGTM!The schema definition for the
api-versionheader and query parameters is correct.
390-408: LGTM!The schema definition for the
200 Successresponse for a list of districts is correct.
425-447: LGTM!The schema definition for the
jwttokenheader andapi-versionheader and query parameters is correct.
455-470: LGTM!The schema definition for the
200 Successresponse for checking if a person has a quality marked photo is correct.
486-508: LGTM!The schema definition for the
jwttokenheader andapi-versionheader and query parameters is correct.
516-531: LGTM!The schema definition for the
200 Successresponse for checking if a person has a quality marked signature is correct.
547-569: LGTM!The schema definition for the
jwttokenheader andapi-versionheader and query parameters is correct.
577-592: LGTM!The schema definition for the
200 Successresponse for getting a quality marked photo is correct.
596-598: LGTM!The schema definition for the
204 No Contentresponse is correct.
611-633: LGTM!The schema definition for the
jwttokenheader andapi-versionheader and query parameters is correct.
641-656: LGTM!The schema definition for the
200 Successresponse for getting a quality marked signature is correct.
libs/api/domains/driving-license/src/lib/drivingLicense.service.ts
Outdated
Show resolved
Hide resolved
libs/api/domains/driving-license/src/lib/drivingLicense.service.ts
Outdated
Show resolved
Hide resolved
libs/api/domains/driving-license/src/lib/drivingLicense.service.ts
Outdated
Show resolved
Hide resolved
libs/api/domains/driving-license/src/lib/drivingLicense.service.ts
Outdated
Show resolved
Hide resolved
libs/api/domains/driving-license/src/lib/drivingLicense.service.ts
Outdated
Show resolved
Hide resolved
…land.is into fix/dld-entry-requirements
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (4)
- libs/api/domains/driving-license/src/lib/drivingLicense.service.ts (3 hunks)
- libs/api/domains/driving-license/src/lib/drivingLicense.type.ts (1 hunks)
- libs/application/core/src/lib/messages.ts (1 hunks)
- libs/application/template-api-modules/src/lib/modules/templates/driving-license-duplicate/driving-license-duplicate.service.ts (2 hunks)
Files skipped from review as they are similar to previous changes (3)
- libs/api/domains/driving-license/src/lib/drivingLicense.service.ts
- libs/api/domains/driving-license/src/lib/drivingLicense.type.ts
- libs/application/template-api-modules/src/lib/modules/templates/driving-license-duplicate/driving-license-duplicate.service.ts
Additional context used
Path-based instructions (1)
libs/application/core/src/lib/messages.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (2)
libs/application/core/src/lib/messages.ts (2)
504-508: Ensure message ID uniqueness and consistency.The message ID for
drivingLicenseDuplicateEntryValidationErrorTitleis unique and follows the naming convention. The default message and description are clear and consistent with existing messages.
515-520: Ensure message ID uniqueness and consistency.The message ID for
drivingLicenseDuplicateEntryValidationExpiredCategoryLicenseErroris unique and follows the naming convention. The default message and description are clear and consistent with existing messages.
…land.is into fix/dld-entry-requirements
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/application/core/src/lib/messages.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- libs/application/core/src/lib/messages.ts
* feat(application-dld): Entry requirements in DP * Cleanup * Fix case * Cleanup * Responding to PR comments * Fix duplicate id --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat(application-dld): Entry requirements in DP * Cleanup * Fix case * Cleanup * Responding to PR comments * Fix duplicate id --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What?
Adding some safeguards against driving license duplicates being accessed by persons who are not eligible according to the criteria of having a sign number 400 or an expired, or soon to be expired, category on their driver's license.
TODO:
Possibly keep a list of Commercial / Heavy driver's licenses (ísl: meirapróf) for which categories to exclude in the expiry check.
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit