Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(application-dld): Entry requirements in DP #15445

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

kksteini
Copy link
Member

@kksteini kksteini commented Jul 4, 2024

Hotfix of #15430

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

* feat(application-dld): Entry requirements in DP

* Cleanup

* Fix case

* Cleanup

* Responding to PR comments

* Fix duplicate id

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@kksteini kksteini requested review from a team as code owners July 4, 2024 13:29
Copy link
Contributor

coderabbitai bot commented Jul 4, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kksteini kksteini added the automerge Merge this PR as soon as all checks pass label Jul 4, 2024
@datadog-island-is
Copy link

Datadog Report

All test runs e121712 🔗

21 Total Test Services: 0 Failed, 20 Passed
🔻 Test Sessions change in coverage: 7 decreased, 2 increased, 76 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 5.28s 1 no change Link
api-domains-driving-license 0 0 0 23 0 40.05s 1 decreased (-0.79%) Link
api-domains-license-service 0 0 0 0 0 771.18ms 1 no change Link
application-api-files 0 0 0 12 0 10.01s 1 increased (+0.02%) Link
application-core 0 0 0 90 0 34.75s 1 decreased (-0.32%) Link
application-system-api 0 0 0 111 2 3m 15.43s 1 decreased (-0.11%) Link
application-template-api-modules 0 0 0 109 0 1m 59.01s 1 decreased (-0.12%) Link
application-templates-accident-notification 0 0 0 98 0 27.2s 1 no change Link
application-templates-criminal-record 0 0 0 2 0 17.52s 1 no change Link
application-templates-driving-license 0 0 0 13 0 25.69s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (7)

This report shows up to 5 code coverage decreases.

  • api-domains-driving-license - jest 33.82% (-0.79%) - Details
  • clients-driving-license - jest 26.26% (-0.61%) - Details
  • license-api - jest 34.16% (-0.42%) - Details
  • application-core - jest 78.61% (-0.32%) - Details
  • application-template-api-modules - jest 25.8% (-0.12%) - Details

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Project coverage is 37.03%. Comparing base (38ba019) to head (69b01e8).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/30.2.0   #15445      +/-   ##
==================================================
- Coverage           37.04%   37.03%   -0.01%     
==================================================
  Files                6539     6539              
  Lines              133085   133107      +22     
  Branches            38119    38125       +6     
==================================================
+ Hits                49296    49299       +3     
- Misses              83789    83808      +19     
Flag Coverage Δ
api 3.44% <ø> (ø)
api-domains-driving-license 44.56% <7.69%> (-0.14%) ⬇️
application-system-api 42.06% <13.63%> (-0.02%) ⬇️
application-templates-accident-notification 19.93% <ø> (ø)
application-templates-car-recycling 4.23% <ø> (ø)
application-templates-criminal-record 22.35% <ø> (ø)
application-templates-driving-license 15.89% <ø> (ø)
application-templates-estate 11.94% <ø> (ø)
application-templates-example-payment 21.01% <ø> (ø)
application-templates-financial-aid 12.14% <ø> (ø)
application-templates-general-petition 19.05% <ø> (ø)
application-templates-health-insurance 23.46% <ø> (ø)
application-templates-inheritance-report 4.65% <ø> (ø)
application-templates-parental-leave 28.34% <ø> (-0.12%) ⬇️
application-ui-components 1.43% <ø> (ø)
application-ui-shell 21.62% <ø> (ø)
clients-driving-license 41.08% <ø> (ø)
clients-license-client 1.84% <ø> (ø)
license-api 43.36% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ins/driving-license/src/lib/drivingLicense.type.ts 100.00% <ø> (ø)
libs/application/core/src/lib/messages.ts 100.00% <ø> (ø)
...nse-duplicate/driving-license-duplicate.service.ts 43.33% <22.22%> (-9.05%) ⬇️
.../driving-license/src/lib/drivingLicense.service.ts 54.72% <7.69%> (-3.26%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ba019...69b01e8. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 89d0078 into release/30.2.0 Jul 4, 2024
85 of 93 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/r30.2.0-application-dld-fix-entry branch July 4, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants