chore: update PDF package #15760
chore: update PDF package #15760
Conversation
Bumps [react-pdf](https://github.com/wojtekmaj/react-pdf/tree/HEAD/packages/react-pdf) from 7.5.0 to 9.1.0. - [Release notes](https://github.com/wojtekmaj/react-pdf/releases) - [Commits](https://github.com/wojtekmaj/react-pdf/commits/v9.1.0/packages/react-pdf) --- updated-dependencies: - dependency-name: react-pdf dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
WalkthroughThe changes involve two main updates: the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Affected services are: air-discount-scheme-api,air-discount-scheme-backend,api,application-system-api,download-service,financial-aid-api,financial-aid-backend,financial-aid-open-api,github-actions-cache,icelandic-names-registry-backend,judicial-system-api,judicial-system-digital-mailbox-api,judicial-system-backend,judicial-system-message-handler,judicial-system-robot-api,judicial-system-scheduler,judicial-system-xrd-api,license-api,reference-backend,regulations-admin-backend,services-auth-admin-api,services-auth-ids-api,services-auth-delegation-api,services-auth-personal-representative,services-auth-personal-representative-public,services-auth-public-api,services-contentful-entry-tagger,services-documents,services-endorsements-api,services-form-system,services-search-indexer,services-sessions,services-university-gateway,services-user-notification,services-user-profile,services-xroad-collector,skilavottord-ws,air-discount-scheme-web,auth-admin-web,consultation-portal,contentful-apps,financial-aid-web-osk,financial-aid-web-veita,judicial-system-web,skilavottord-web,web,application-system-form,island-ui-storybook,portals-admin,service-portal,system-e2e,external-contracts-tests, Deployed services: application-system-api,application-system-form,service-portal,service-portal-api,portals-admin,consultation-portal,api,web,xroad-collector,skilavottord-web,skilavottord-ws,services-documents,island-ui-storybook,download-service,icelandic-names-registry-backend,endorsement-system-api,air-discount-scheme-web,air-discount-scheme-backend,air-discount-scheme-api,regulations-admin-backend,external-contracts-tests,application-system-api-worker,license-api,services-sessions,services-sessions-worker,services-sessions-cleanup,services-university-gateway,services-university-gateway-worker. |
Datadog ReportAll test runs ✅ 101 Total Test Services: 0 Failed, 99 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (4) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (2)
- libs/island-ui/core/src/lib/PdfViewer/PdfViewer.tsx (1 hunks)
- package.json (1 hunks)
Additional context used
Path-based instructions (1)
libs/island-ui/core/src/lib/PdfViewer/PdfViewer.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (2)
libs/island-ui/core/src/lib/PdfViewer/PdfViewer.tsx (1)
48-48: LGTM!The change to use an ES module format for the worker source URL is a good practice and aligns with modern JavaScript environments.
package.json (1)
261-261: Verify that updating thereact-pdfpackage version does not introduce any breaking changes.Ensure that the application code is compatible with the changes introduced in
react-pdfversion9.1.0, especially the modifications related to thePdfViewercomponent and the worker source URL.Run the following script to search for any issues related to the
react-pdfpackage update:Verification successful
Verification successful: No breaking changes found with the
react-pdfpackage update.The update to
react-pdfversion9.1.0appears to be compatible with the existing codebase. ThePdfViewercomponent and the worker source URL are correctly configured to use the ES module format. No issues were identified in the search results.
- The
PdfViewercomponent is used in multiple files without issues.- The worker source URL is set using the ES module format in
PdfViewer.tsx.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for any issues related to the react-pdf package update. # Test: Search for the PdfViewer component usage. Expect: No issues with the worker source URL. rg --type typescript --type javascript --glob '!node_modules' -A 5 $'PdfViewer' # Test: Search for any other usage of the react-pdf package. Expect: No breaking changes. rg --type typescript --type javascript --glob '!node_modules' -A 5 $'react-pdf'Length of output: 227
Script:
#!/bin/bash # Description: Search for any issues related to the react-pdf package update. # Test: Search for the PdfViewer component usage. Expect: No issues with the worker source URL. rg --type js --type ts --glob '!node_modules' -A 5 $'PdfViewer' # Test: Search for any other usage of the react-pdf package. Expect: No breaking changes. rg --type js --type ts --glob '!node_modules' -A 5 $'react-pdf'Length of output: 36137
oddsson
added
automerge
* chore(deps): bump react-pdf from 7.5.0 to 9.1.0 Bumps [react-pdf](https://github.com/wojtekmaj/react-pdf/tree/HEAD/packages/react-pdf) from 7.5.0 to 9.1.0. - [Release notes](https://github.com/wojtekmaj/react-pdf/releases) - [Commits](https://github.com/wojtekmaj/react-pdf/commits/v9.1.0/packages/react-pdf) --- updated-dependencies: - dependency-name: react-pdf dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore: update pdf package --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
PDF package update ✨
Some letters were not rendering correctly in previous version when users were opening documents in service portal.
"Þið eruð að nota react-pdf 7.5.0 sem notar undirliggjandi pdf-js, það notar útgáfu 3.11.174 af PDF-JS.
Eftir að við fórum í pdf-js 4.x ( sem nýjasta útgáfa af React-pdf notar ) þá höfum við ekki lent í þessu vandamáli.
Er möguleiki að þið getið uppfært PDF viewerinn ykkar. Sá að dependabot er búið að gera þessu PR hjá ykkur á github"
#15546
Hopefully this update will fix this issue 🙏🏼
Checklist:
Summary by CodeRabbit
New Features
react-pdflibrary to version 9.1.0, potentially introducing new features and performance improvements.Bug Fixes
PdfViewercomponent by updating the worker source to use ES module format.