fix(island-ui): Update url for pdf worker #16273
Conversation
WalkthroughThe changes in this pull request involve a modification to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16273 +/- ##
=======================================
Coverage 36.92% 36.92%
=======================================
Files 6781 6781
Lines 140031 140031
Branches 39816 39816
=======================================
Hits 51705 51705
Misses 88326 88326 Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
libs/island-ui/core/src/lib/PdfViewer/PdfViewer.tsx (1)
48-49: LGTM! Consider using an environment variable for the worker URL.The update to the PDF worker URL aligns with the PR objective and maintains the component's reusability. The use of a CDN (Contentful) for hosting the worker file is a good practice for performance.
Consider using an environment variable for the worker URL to make it easier to update in the future and to keep sensitive information out of the codebase. For example:
pdf.pdfjs.GlobalWorkerOptions.workerSrc = process.env.PDF_WORKER_URL || 'https://assets.ctfassets.net/8k0h54kbe6bj/8dqL0H07pYWZEkXwLtgBp/1c347f9a4f2bb255f78389b42cf40b97/pdf.worker.min.mjs'This change would improve maintainability and allow for easier configuration across different environments.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- libs/island-ui/core/src/lib/PdfViewer/PdfViewer.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/island-ui/core/src/lib/PdfViewer/PdfViewer.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Datadog ReportAll test runs ✅ 34 Total Test Services: 0 Failed, 33 Passed Test ServicesThis report shows up to 10 services
|
* fix(island-ui): Update url for pdf worker (#16273) * fix(island-ui): pdf viewer worker url (#16280) * Update url * Update url * Update url --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Update worker url
Why
We need the new version to depend on legacy for browser support.
Checklist:
Summary by CodeRabbit