Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driving-license): hotfix/jurisdictionid back in dl #15940

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

albinagu
Copy link
Member

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

albinagu and others added 3 commits September 4, 2024 12:48
* fix(driving-license): digital license, no pickup

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix(driving-license): adding back JurisdictionApi check

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
@albinagu albinagu requested a review from a team as a code owner September 10, 2024 14:11
@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Sep 10, 2024
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 10, 2024

Datadog Report

All test runs 9bed72c 🔗

5 Total Test Services: 0 Failed, 5 Passed
⬆️ Test Sessions change in coverage: 4 increased, 4 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.19s 1 no change Link
application-system-api 0 0 0 111 2 3m 22.97s 1 increased (+0.09%) Link
application-template-api-modules 0 0 0 109 0 1m 50.3s 1 increased (+0.04%) Link
application-templates-driving-license 0 0 0 13 0 16.9s 1 increased (+0.16%) Link
application-ui-shell 0 0 0 74 0 35.22s 1 increased (+0.12%) Link

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.94%. Comparing base (690fb3e) to head (8814f41).
Report is 1 commits behind head on release/31.2.0.

Files with missing lines Patch % Lines
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/31.2.0   #15940      +/-   ##
==================================================
- Coverage           36.94%   36.94%   -0.01%     
==================================================
  Files                6681     6682       +1     
  Lines              136472   136475       +3     
  Branches            38750    38750              
==================================================
  Hits                50416    50416              
- Misses              86056    86059       +3     
Flag Coverage Δ
api 3.39% <ø> (ø)
application-system-api 41.74% <ø> (-0.01%) ⬇️
application-template-api-modules 23.65% <ø> (-0.01%) ⬇️
application-templates-driving-license 15.93% <0.00%> (-0.04%) ⬇️
application-ui-shell 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mplates/driving-license/src/dataProviders/index.ts 100.00% <ø> (ø)
...templates/driving-license/src/forms/draft/draft.ts 0.00% <ø> (ø)
...nse/src/forms/prerequisites/sectionExternalData.ts 0.00% <ø> (ø)
.../driving-license/src/lib/drivingLicenseTemplate.ts 9.67% <ø> (ø)
...tion/templates/driving-license/src/lib/messages.ts 100.00% <ø> (ø)
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690fb3e...8814f41. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 38154ed into release/31.2.0 Sep 10, 2024
47 of 56 checks passed
@kodiakhq kodiakhq bot deleted the hotfix/jurisdictionid_back_in_dl branch September 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants