Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driving-license): adding back JurisdictionApi check #15938

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

albinagu
Copy link
Member

@albinagu albinagu commented Sep 10, 2024

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Introduced a new sub-section in the driving license application form for delivery-related information.
    • Added the JurisdictionApi to enhance data handling and jurisdiction-specific features.
    • Implemented new message definitions for improved localization support in the application.
  • Bug Fixes

    • Enhanced control flow to accommodate new form sections and data providers, improving overall application stability.

@albinagu albinagu requested a review from a team as a code owner September 10, 2024 13:14
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Walkthrough

The pull request introduces several enhancements to the driving license application framework. Key changes include the addition of the JurisdictionApi to various modules, enabling jurisdiction-specific data handling. A new sub-section for delivery information is added to the draft form, improving data collection capabilities. Additionally, new message definitions are introduced for localization support, enhancing user experience during the application process.

Changes

File Change Summary
libs/application/templates/driving-license/src/dataProviders/index.ts Added export of JurisdictionApi.
libs/application/templates/driving-license/src/forms/draft/draft.ts Added import for subSectionDelivery and integrated it into the draft form.
libs/application/templates/driving-license/src/forms/draft/subSectionDelivery.ts Created subSectionDelivery component for handling delivery-related information.
libs/application/templates/driving-license/src/forms/prerequisites/sectionExternalData.ts Added JurisdictionApi as a data provider in sectionExternalData.
libs/application/templates/driving-license/src/lib/drivingLicenseTemplate.ts Included JurisdictionApi in import statements and template type parameters.
libs/application/templates/driving-license/src/lib/messages.ts Added new message definitions: pickupLocationTitle and districtCommisionerPickup.

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 83d28e9 and ba00ff7.

Files selected for processing (1)
  • libs/application/templates/driving-license/src/forms/draft/subSectionDelivery.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • libs/application/templates/driving-license/src/forms/draft/subSectionDelivery.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.80%. Comparing base (c280c15) to head (ba00ff7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15938      +/-   ##
==========================================
- Coverage   36.81%   36.80%   -0.01%     
==========================================
  Files        6691     6692       +1     
  Lines      137091   137094       +3     
  Branches    38968    38968              
==========================================
  Hits        50464    50464              
- Misses      86627    86630       +3     
Flag Coverage Δ
api 3.39% <ø> (ø)
application-system-api 41.67% <ø> (ø)
application-template-api-modules 23.54% <ø> (ø)
application-templates-driving-license 15.58% <0.00%> (-0.04%) ⬇️
application-ui-shell 21.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mplates/driving-license/src/dataProviders/index.ts 100.00% <ø> (ø)
...templates/driving-license/src/forms/draft/draft.ts 0.00% <ø> (ø)
...nse/src/forms/prerequisites/sectionExternalData.ts 0.00% <ø> (ø)
.../driving-license/src/lib/drivingLicenseTemplate.ts 9.67% <ø> (ø)
...tion/templates/driving-license/src/lib/messages.ts 100.00% <ø> (ø)
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c280c15...ba00ff7. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 10, 2024

Datadog Report

All test runs ed89286 🔗

5 Total Test Services: 0 Failed, 5 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.04%), 7 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.03s 1 no change Link
application-system-api 0 0 0 111 2 3m 37.35s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 54.01s 1 no change Link
application-templates-driving-license 0 0 0 13 0 17.02s 1 decreased (-0.04%) Link
application-ui-shell 0 0 0 74 0 36.29s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • application-templates-driving-license - jest 20.11% (-0.04%) - Details

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Sep 10, 2024
@kodiakhq kodiakhq bot merged commit 05c7602 into main Sep 10, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the revert_change_dl branch September 10, 2024 13:26
albinagu added a commit that referenced this pull request Sep 10, 2024
* fix(driving-license): adding back JurisdictionApi check

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
kodiakhq bot added a commit that referenced this pull request Sep 10, 2024
* fix(driving-license): digital license, no pickup (#15881)

* fix(driving-license): digital license, no pickup

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

* fix(driving-license): adding back JurisdictionApi check (#15938)

* fix(driving-license): adding back JurisdictionApi check

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>

---------

Co-authored-by: andes-it <builders@andes.is>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jonnigs pushed a commit that referenced this pull request Sep 12, 2024
* fix(driving-license): adding back JurisdictionApi check

* chore: nx format:write update dirty files

---------

Co-authored-by: andes-it <builders@andes.is>
@coderabbitai coderabbitai bot mentioned this pull request Sep 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants