Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driving-license): 65 renewal updates #15946

Merged
merged 7 commits into from
Sep 11, 2024
Merged

fix(driving-license): 65 renewal updates #15946

merged 7 commits into from
Sep 11, 2024

Conversation

albinagu
Copy link
Member

@albinagu albinagu commented Sep 10, 2024

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced health declaration logic to simplify display conditions for applications.
    • Introduced specific messaging for full license renewals for individuals aged 65 and older.
    • Added functionality to assess if a user is younger than 65 using both real and fake data.
    • Improved delivery options with new pickup selection for postal or district delivery.
    • Added contextual information for pickup locations in the summary section.
  • Bug Fixes

    • Removed unnecessary dependencies to streamline the quality photo section.
    • Corrected message identifiers for clarity and consistency.
  • Refactor

    • Consolidated logic for health declarations, simplifying the user interface.
    • Expanded constants for better handling of pickup types.

@albinagu albinagu requested a review from a team as a code owner September 10, 2024 15:50
Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Warning

Rate limit exceeded

@albinagu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 27 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 43f6153 and c9a3481.

Walkthrough

The pull request introduces modifications to the driving license application templates, focusing on the health declaration logic, age-related checks, and delivery options. It consolidates the display conditions for health declaration fields based on application type rather than age alone, enhances messaging for renewal applications for individuals aged 65 and older, and adds a function to determine if a user is younger than 65. Additionally, it introduces new constants and updates message definitions related to pickup locations.

Changes

Files Change Summary
libs/application/templates/driving-license/src/forms/draft/subSectionHealthDeclaration.ts Updated condition logic to simplify age checks; removed age-specific multi-field.
libs/application/templates/driving-license/src/forms/draft/subSectionQualityPhoto.ts Removed import of hasYes function.
libs/application/templates/driving-license/src/forms/draft/subSectionDelivery.ts Added radio field for pickup options; modified delivery logic based on application type.
libs/application/templates/driving-license/src/forms/draft/subSectionSummary.ts Added key-value field for displaying pickup location based on user responses.
libs/application/templates/driving-license/src/lib/drivingLicenseTemplate.ts Introduced B_FULL_RENEWAL_65 constant for renewal messaging for users aged 65 and older.
libs/application/templates/driving-license/src/lib/utils/formUtils.ts Added isYoungerThan65 function; included imports for DrivingLicenseFakeData and NationalRegistryUser.
libs/application/templates/driving-license/src/lib/constants.ts Introduced Pickup enum for structured pickup type references.
libs/application/templates/driving-license/src/lib/messages.ts Modified and added messages related to pickup locations; corrected naming conventions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant HealthDeclaration

    User->>Application: Submit application
    Application->>HealthDeclaration: Check conditions
    alt Application type is full renewal for 65+
        HealthDeclaration->>Application: Display health declaration
    else Other application types
        HealthDeclaration->>Application: Do not display health declaration
    end
Loading

Possibly related PRs

Suggested labels

automerge


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 36.83%. Comparing base (72fc394) to head (c9a3481).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...iving-license/src/forms/draft/subSectionSummary.ts 0.00% 6 Missing ⚠️
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% 2 Missing ⚠️
...nse/src/forms/draft/subSectionHealthDeclaration.ts 0.00% 2 Missing ⚠️
.../driving-license/src/lib/drivingLicenseTemplate.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15946      +/-   ##
==========================================
- Coverage   36.84%   36.83%   -0.02%     
==========================================
  Files        6714     6706       -8     
  Lines      137619   137190     -429     
  Branches    39113    38966     -147     
==========================================
- Hits        50705    50529     -176     
+ Misses      86914    86661     -253     
Flag Coverage Δ
api 3.39% <ø> (ø)
application-system-api 41.69% <ø> (+<0.01%) ⬆️
application-template-api-modules 23.49% <ø> (+0.01%) ⬆️
application-templates-driving-license 15.58% <0.00%> (ø)
application-ui-shell 21.08% <ø> (ø)
skilavottord-ws 24.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-license/src/forms/draft/subSectionQualityPhoto.ts 0.00% <ø> (ø)
...ion/templates/driving-license/src/lib/constants.ts 100.00% <ø> (ø)
...tion/templates/driving-license/src/lib/messages.ts 100.00% <ø> (ø)
...ving-license/src/forms/draft/subSectionDelivery.ts 0.00% <0.00%> (ø)
...nse/src/forms/draft/subSectionHealthDeclaration.ts 0.00% <0.00%> (ø)
.../driving-license/src/lib/drivingLicenseTemplate.ts 9.09% <0.00%> (-0.59%) ⬇️
...iving-license/src/forms/draft/subSectionSummary.ts 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72fc394...c9a3481. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 10, 2024

Datadog Report

All test runs b521ce9 🔗

6 Total Test Services: 0 Failed, 6 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.02%), 9 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 2.76s 1 no change Link
application-system-api 0 0 0 111 2 3m 15s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 51.11s 1 no change Link
application-templates-driving-license 0 0 0 13 0 17.13s 1 increased (+0.02%) Link
application-ui-shell 0 0 0 74 0 36.41s 1 no change Link
skilavottord-ws 0 0 0 1 0 19.55s 1 no change Link

@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Sep 11, 2024
@albinagu albinagu removed the automerge Merge this PR as soon as all checks pass label Sep 11, 2024
@albinagu albinagu added the automerge Merge this PR as soon as all checks pass label Sep 11, 2024
@kodiakhq kodiakhq bot merged commit f885cca into main Sep 11, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the 65_renewal_updates branch September 11, 2024 16:05
jonnigs pushed a commit that referenced this pull request Sep 12, 2024
* fix(driving-license): 65 renewal updates

* adding home delivery - 65+

* tweaks

* cleanup

* cleanup

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Sep 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants