fix(j-s): Merge Email

[gudjong]

Merge Email

Sameina mál - Tölvupóstur við sameinað mál, Niðustaða: Sameinað

What

• Fixes the case conclusion when an indictment is closed as merge with another case.

Why

• Verified bug.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Introduced a new property in notifications to reflect case status changes.
  • Enhanced notification email subject to indicate when a case has been merged.
  • Added functionality to provide human-readable descriptions for the "Merged" case ruling decision.

• Bug Fixes

  • Improved human-readable descriptions for case ruling decisions, including the new "Merged" status.

[coderabbitai]

Walkthrough

The changes involve the addition of a new property, indictmentRulingDecision, to a case object in the InternalNotificationController test, which modifies the expected outcome of the notification. Additionally, a new case handling for CaseIndictmentRulingDecision.MERGE is introduced in the getHumanReadableCaseIndictmentRulingDecision function, allowing for a human-readable description of this ruling decision.

Changes

File Path	Change Summary
apps/judicial-system/backend/src/app/modules/notification/test/...	Added indictmentRulingDecision: CaseIndictmentRulingDecision.MERGE to the case object in tests.
libs/judicial-system/formatters/src/lib/formatters.ts	Added handling for CaseIndictmentRulingDecision.MERGE in getHumanReadableCaseIndictmentRulingDecision.

Possibly related PRs

• feat(j-s): Create ruling confirmation #15894: The changes in this PR involve the handling of ruling confirmations, which is directly related to the modifications made in the main PR regarding the indictmentRulingDecision and its implications for notifications.
• fix(j-s): Allow prison system users to see rulings #15935: This PR enhances the visibility of ruling case files for prison system users, which connects to the changes in the main PR that involve the CaseIndictmentRulingDecision.MERGE, indicating a broader context of handling rulings within the system.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.77%. Comparing base (7de9b13) to head (de896ea).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16011      +/-   ##
==========================================
- Coverage   36.77%   36.77%   -0.01%     
==========================================
  Files        6733     6733              
  Lines      138101   138103       +2     
  Branches    39238    39239       +1     
==========================================
- Hits        50783    50781       -2     
- Misses      87318    87322       +4     

Flag	Coverage Δ
air-discount-scheme-backend	54.10% <ø> (ø)
air-discount-scheme-web	0.00% <ø> (ø)
api	3.39% <ø> (ø)
api-domains-air-discount-scheme	36.85% <ø> (ø)
api-domains-assets	26.71% <ø> (ø)
api-domains-auth-admin	49.89% <ø> (ø)
api-domains-communications	40.44% <ø> (ø)
api-domains-criminal-record	47.77% <ø> (ø)
api-domains-driving-license	44.32% <ø> (ø)
api-domains-education	31.32% <ø> (ø)
api-domains-health-insurance	34.58% <ø> (ø)
api-domains-mortgage-certificate	35.73% <ø> (ø)
api-domains-payment-schedule	41.14% <ø> (ø)
application-api-files	57.54% <ø> (ø)
application-core	72.33% <ø> (ø)
application-system-api	41.66% <ø> (ø)
application-template-api-modules	23.48% <ø> (+0.01%)	⬆️
application-templates-accident-notification	22.26% <ø> (ø)
application-templates-car-recycling	3.12% <ø> (ø)
application-templates-criminal-record	26.96% <ø> (ø)
application-templates-driving-license	18.75% <ø> (ø)
application-templates-estate	12.57% <ø> (ø)
application-templates-example-payment	25.72% <ø> (ø)
application-templates-financial-aid	14.39% <ø> (ø)
application-templates-general-petition	23.95% <ø> (ø)
application-templates-health-insurance	26.88% <ø> (ø)
application-templates-inheritance-report	6.45% <ø> (ø)
application-templates-marriage-conditions	15.35% <ø> (ø)
application-templates-mortgage-certificate	44.15% <ø> (ø)
application-templates-parental-leave	29.31% <ø> (ø)
application-types	6.74% <ø> (ø)
application-ui-components	1.52% <ø> (ø)
application-ui-shell	21.75% <ø> (ø)
auth-react	22.84% <ø> (ø)
clients-charge-fjs-v2	24.11% <ø> (ø)
clients-driving-license	40.56% <ø> (ø)
clients-driving-license-book	43.85% <ø> (ø)
clients-financial-statements-inao	49.10% <ø> (ø)
clients-license-client	1.83% <ø> (ø)
clients-middlewares	72.82% <ø> (ø)
clients-regulations	42.54% <ø> (ø)
clients-rsk-company-registry	29.76% <ø> (ø)
clients-syslumenn	49.75% <ø> (ø)
cms	0.42% <ø> (ø)
cms-translations	39.59% <ø> (ø)
contentful-apps	5.76% <ø> (ø)
download-service	44.60% <ø> (ø)
financial-aid-backend	56.52% <ø> (ø)
financial-aid-shared	19.03% <ø> (ø)
island-ui-core	28.60% <ø> (ø)
judicial-system-api	19.37% <ø> (ø)
judicial-system-backend	55.20% <100.00%> (-0.01%)	⬇️
judicial-system-formatters	79.67% <0.00%> (-0.19%)	⬇️
judicial-system-web	28.71% <0.00%> (-0.01%)	⬇️
license-api	42.79% <ø> (-0.14%)	⬇️
portals-admin-regulations-admin	1.96% <ø> (ø)
portals-core	16.16% <ø> (ø)
services-auth-admin-api	52.87% <ø> (ø)
services-auth-delegation-api	61.38% <ø> (ø)
services-auth-ids-api	54.03% <ø> (+0.01%)	⬆️
services-auth-personal-representative	47.98% <ø> (+0.03%)	⬆️
services-auth-personal-representative-public	43.91% <ø> (+0.04%)	⬆️
services-auth-public-api	51.81% <ø> (+0.01%)	⬆️
services-endorsements-api	55.02% <ø> (ø)
services-university-gateway	48.59% <ø> (+0.17%)	⬆️
services-user-notification	47.62% <ø> (ø)
services-user-profile	62.28% <ø> (ø)
shared-components	27.67% <ø> (ø)
shared-form-fields	31.60% <ø> (ø)
shared-utils	28.91% <ø> (ø)
web	1.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/judicial-system/formatters/src/lib/formatters.ts	79.67% <100.00%> (-0.87%)	⬇️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de9b13...de896ea. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs c810604 🔗

✅ 9 Total Test Services: 0 Failed, 9 Passed
🔻 Test Sessions change in coverage: 2 decreased, 10 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
judicial-system-api	0	0	0	57	0	5.93s	1 no change	Link
judicial-system-backend	0	0	0	21197	0	18m 49.08s	1 no change	Link
judicial-system-formatters	0	0	0	36	0	5.2s	1 decreased (-0.12%)	Link
judicial-system-message	0	0	0	32	0	10.91s	1 no change	Link
judicial-system-message-handler	0	0	0	4	0	3.64s	1 no change	Link
judicial-system-scheduler	0	0	0	4	0	4.25s	1 no change	Link
judicial-system-types	0	0	0	23	0	7.5s	1 no change	Link
judicial-system-web	0	0	0	338	0	1m 9.9s	1 no change	Link
judicial-system-xrd-api	0	0	0	6	0	5.3s	1 decreased (-0.06%)	Link

🔻 Code Coverage Decreases vs Default Branch (2)

• judicial-system-formatters - jest 88.02% (-0.12%) - Details
• judicial-system-xrd-api - jest 74.09% (-0.06%) - Details