Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-portal): Add error toast to overveiw #16021

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

thordurhhh
Copy link
Member

@thordurhhh thordurhhh commented Sep 16, 2024

What

Add error toast to overveiw

Why

No error message when docs fail on overview

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced error handling for document fetching, providing toast notifications for immediate feedback when applicable.
    • Introduced a new parameter in the focus hook to control focus-related event listeners, improving flexibility for users.
  • Bug Fixes

    • Improved user experience by differentiating error display methods based on the context of use.

Sorry, something went wrong.

@thordurhhh thordurhhh added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Sep 16, 2024
@thordurhhh thordurhhh marked this pull request as ready for review September 16, 2024 11:04
@thordurhhh thordurhhh requested a review from a team as a code owner September 16, 2024 11:04
Copy link
Contributor

coderabbitai bot commented Sep 16, 2024

Walkthrough

The changes enhance the error handling logic in the DocumentLineV2.tsx file by introducing a conditional check based on the asFrame variable during document fetching. Depending on the value of asFrame, errors are either displayed via a toast notification or assigned to a state variable. Additionally, the useIsChildFocusedorHovered hook has been updated to include a new parameter, focus, which allows control over the addition of focus-related event listeners.

Changes

File Path Change Summary
libs/service-portal/documents/src/components/DocumentLine/DocumentLineV2.tsx Modified error handling logic in the onError callback to conditionally display errors based on asFrame.
libs/service-portal/documents/src/hooks/useIsChildFocused.ts Added a focus parameter to useIsChildFocusedorHovered hook to control focus event listener behavior.

Possibly related PRs

  • fix: init #15975: This PR modifies conditional rendering logic related to error handling in a component, which is conceptually similar to the changes made in the main PR regarding error handling in the DocumentLineV2.tsx file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (02e8a3c) to head (333b1f2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16021   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files        6721     6721           
  Lines      137870   137870           
  Branches    39197    39197           
=======================================
+ Hits        50754    50755    +1     
+ Misses      87116    87115    -1     
Flag Coverage Δ
air-discount-scheme-backend 54.07% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.39% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 36.85% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 49.89% <ø> (ø)
api-domains-communications 40.42% <ø> (ø)
api-domains-criminal-record 47.77% <ø> (ø)
api-domains-driving-license 44.27% <ø> (ø)
api-domains-education 31.22% <ø> (ø)
api-domains-health-insurance 34.58% <ø> (ø)
api-domains-mortgage-certificate 35.73% <ø> (ø)
api-domains-payment-schedule 41.14% <ø> (ø)
application-api-files 57.46% <ø> (ø)
application-core 72.00% <ø> (-0.34%) ⬇️
application-system-api 41.67% <ø> (ø)
application-template-api-modules 23.47% <ø> (+0.01%) ⬆️
application-templates-accident-notification 22.26% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.96% <ø> (ø)
application-templates-driving-license 18.75% <ø> (ø)
application-templates-estate 12.55% <ø> (ø)
application-templates-example-payment 25.72% <ø> (ø)
application-templates-financial-aid 14.39% <ø> (ø)
application-templates-general-petition 23.95% <ø> (ø)
application-templates-health-insurance 26.88% <ø> (ø)
application-templates-inheritance-report 6.45% <ø> (ø)
application-templates-marriage-conditions 15.35% <ø> (ø)
application-templates-mortgage-certificate 44.15% <ø> (ø)
application-templates-parental-leave 29.31% <ø> (ø)
application-types 6.74% <ø> (ø)
application-ui-components 1.52% <ø> (ø)
application-ui-shell 21.74% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 30.83% <ø> (ø)
auth-react 22.82% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.56% <ø> (ø)
clients-driving-license-book 43.85% <ø> (ø)
clients-financial-statements-inao 49.10% <ø> (ø)
clients-license-client 1.83% <ø> (ø)
clients-middlewares 72.83% <ø> (+0.08%) ⬆️
clients-regulations 42.54% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.75% <ø> (ø)
clients-zendesk 55.65% <ø> (ø)
cms 0.42% <ø> (ø)
cms-translations 39.57% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.50% <ø> (ø)
contentful-apps 5.76% <ø> (ø)
dokobit-signing 62.85% <ø> (ø)
download-service 44.55% <ø> (ø)
email-service 60.65% <ø> (ø)
feature-flags 90.69% <ø> (ø)
file-storage 53.01% <ø> (ø)
financial-aid-backend 56.52% <ø> (ø)
financial-aid-shared 19.03% <ø> (ø)
icelandic-names-registry-backend 54.64% <ø> (ø)
infra-nest-server 48.95% <ø> (ø)
infra-tracing 43.24% <ø> (ø)
island-ui-core 28.59% <ø> (ø)
judicial-system-api 19.35% <ø> (ø)
judicial-system-audit-trail 68.53% <ø> (ø)
judicial-system-backend 55.72% <ø> (ø)
judicial-system-formatters 79.83% <ø> (ø)
judicial-system-message 66.79% <ø> (ø)
judicial-system-message-handler 47.61% <ø> (ø)
judicial-system-scheduler 68.98% <ø> (ø)
judicial-system-types 48.34% <ø> (ø)
judicial-system-web 28.71% <ø> (ø)
license-api 42.76% <ø> (-0.08%) ⬇️
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 68.50% <ø> (+0.78%) ⬆️
nest-audit 68.20% <ø> (ø)
nest-config 78.07% <ø> (ø)
nest-feature-flags 51.91% <ø> (ø)
nest-problem 46.48% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.71% <ø> (ø)
nova-sms 62.18% <ø> (ø)
portals-admin-regulations-admin 1.96% <ø> (ø)
portals-core 16.14% <ø> (ø)
reference-backend 50.57% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.83% <ø> (ø)
services-auth-delegation-api 61.39% <ø> (+0.07%) ⬆️
services-auth-ids-api 54.02% <ø> (-0.02%) ⬇️
services-auth-personal-representative 47.95% <ø> (-0.04%) ⬇️
services-auth-personal-representative-public 43.89% <ø> (-0.02%) ⬇️
services-auth-public-api 51.81% <ø> (ø)
services-documents 61.26% <ø> (ø)
services-endorsements-api 54.98% <ø> (ø)
services-sessions 65.79% <ø> (+0.04%) ⬆️
services-university-gateway 48.42% <ø> (-0.09%) ⬇️
services-user-notification 47.61% <ø> (ø)
services-user-profile 62.26% <ø> (ø)
shared-components 27.65% <ø> (ø)
shared-form-fields 31.58% <ø> (ø)
shared-mocking 64.62% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 29.26% <ø> (ø)
skilavottord-ws 24.34% <ø> (ø)
web 1.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e8a3c...333b1f2. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 16, 2024

Datadog Report

All test runs 8b30ed2 🔗

101 Total Test Services: 0 Failed, 99 Passed
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 194 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 81 0 23.07s N/A Link
air-discount-scheme-web 0 0 0 2 0 8.17s N/A Link
api 0 0 0 4 0 2.93s N/A Link
api-catalogue-services 0 0 0 23 0 12.33s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 19.54s N/A Link
api-domains-assets 0 0 0 3 0 12.41s N/A Link
api-domains-auth-admin 0 0 0 18 0 13.2s 1 no change Link
api-domains-communications 0 0 0 5 0 28.8s N/A Link
api-domains-criminal-record 0 0 0 5 0 8.69s N/A Link
api-domains-driving-license 0 0 0 23 0 32.54s N/A Link

🔻 Code Coverage Decreases vs Default Branch (3)

  • services-university-gateway - jest 44.85% (-0.03%) - Details
  • services-auth-personal-representative-public - jest 45.91% (-0.01%) - Details
  • license-api - jest 33.87% (-0.01%) - Details

@kodiakhq kodiakhq bot merged commit 97928c5 into main Sep 16, 2024
258 checks passed
@kodiakhq kodiakhq bot deleted the service-portal/overview-error-toast branch September 16, 2024 16:00
@coderabbitai coderabbitai bot mentioned this pull request Jan 10, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants